Project

General

Profile

Actions

action #37985

closed

[functional][y][hard] Make installation_overview page processing consistent (installation_overview and installation_overview_before are either unified or serve single purpose)

Added by nicksinger almost 6 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Bugs in existing tests
Target version:
SUSE QA - Milestone 25
Start date:
2018-06-28
Due date:
2019-04-09
% Done:

0%

Estimated time:
8.00 h
Difficulty:
hard

Description

Observation

We've a module called "installation_overview_before" which can - depending on set variables (e.g. WORKAROUND_DEPS or BREAK_DEPS) - handle broken dependencies while installing SLES.
In the most recent build of SP4 we noticed that this module is sometimes scheduled, sometimes not.
Also the already mentioned variables are set for some testsuites but not all of them.

An example of a functional test scheduling this module is:
https://openqa.suse.de/tests/latest?version=15-SP1&arch=x86_64&machine=64bit&test=allmodules%2Ballpatterns&flavor=Installer-DVD&distri=sle

Problem

How do we want to continue using this module? We should decide on one single solution. Current suggestions of mine would be:

  1. Schedule it on all tests we run which install SLES
  2. Only schedule it in specific test-cases (I already saw some testsuite containing something like "+workaround_modules" on OSD)
  3. Don't schedule it at all and remove the module if it is not needed/useful any longer (I somehow doubt that)

The question after all is, if we can use and apply the modules function (what does it actually do?) in a useful way for our automated tests.

Acceptance criteria

  1. installation_overview and installation_overview_before are unified into single module or separated by functional load (one per module)
  2. Name of the module reflects the purpose of the module

Additional info

I've set the difficulty of this to [hard] since there are maybe hundreds of tests using this module. Figuring out where it is needed, what it does and ultimately adjusting the module could have a big impact on automated testing.

Excerpt from IRC where this question was raised:

13:29 <nsinger> okurz: I wonder why we've a module for workarounding dep-issues but it is only active in "allpatterns"
13:29 <nsinger> okurz: is this by accident? Worth a poo to include this module in every installation?
13:30 <okurz> nsinger: yes please. I guess we should not try to answer this today because it needs a bit of "history lesson" before we can go further but IMHO we can improve -> please create ticket
13:31 <nsinger> okurz: that's why I asked. I knew there is some history I'm not aware of :D

Related issues 2 (0 open2 closed)

Related to openQA Tests - action #40331: [functional][y] select_patterns_and_packages ignores dependency issuesResolvedriafarov2018-08-282019-01-29

Actions
Copied to openQA Tests - action #50180: [functional][y] Make installation_overview page processing consistent (installation_overview and installation_overview_before are either unified or serve single purpose)Resolvedybonatakis2018-06-282019-06-04

Actions
Actions #1

Updated by okurz almost 6 years ago

  • Subject changed from [functional][y] Investigate the existence of installation_overview_before to [functional][y][hard] Investigate the existence of installation_overview_before
  • Target version set to Milestone 21+
Actions #2

Updated by okurz over 5 years ago

  • Target version changed from Milestone 21+ to Milestone 23
Actions #3

Updated by okurz over 5 years ago

  • Related to action #40331: [functional][y] select_patterns_and_packages ignores dependency issues added
Actions #4

Updated by okurz about 5 years ago

  • Due date set to 2019-03-26
Actions #5

Updated by riafarov about 5 years ago

  • Subject changed from [functional][y][hard] Investigate the existence of installation_overview_before to [functional][y][hard] Make installation_overview page processing consistent (unify or schedule properly installation_overview and installation_overview_before)
Actions #6

Updated by riafarov about 5 years ago

  • Subject changed from [functional][y][hard] Make installation_overview page processing consistent (unify or schedule properly installation_overview and installation_overview_before) to [functional][y][hard] Make installation_overview page processing consistent (installation_overview and installation_overview_before are either unified or serve single purpose)
  • Description updated (diff)
Actions #7

Updated by riafarov about 5 years ago

  • Status changed from New to Workable
Actions #8

Updated by riafarov about 5 years ago

  • Description updated (diff)
  • Estimated time set to 8.00 h
Actions #9

Updated by riafarov about 5 years ago

  • Due date changed from 2019-03-26 to 2019-04-09

Postponing.

Actions #10

Updated by ybonatakis about 5 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #11

Updated by riafarov about 5 years ago

  • Target version changed from Milestone 23 to Milestone 24
Actions #12

Updated by ybonatakis about 5 years ago

PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/7156

The installation_overview_before doesnt seem to be in any use. So it s been removed and adjusted the module(s) which are depended from that module in some way. Particular, there was a dependency to the change_desktop which seems to take care of some dependency conflicts.

Actions #13

Updated by riafarov about 5 years ago

  • Copied to action #50180: [functional][y] Make installation_overview page processing consistent (installation_overview and installation_overview_before are either unified or serve single purpose) added
Actions #14

Updated by riafarov about 5 years ago

  • Status changed from In Progress to Resolved

PR is not merged, follow-up: #50180

Actions #16

Updated by ybonatakis almost 5 years ago

  • Status changed from Resolved to In Progress

i have to reopen it as there are some issues and the changes have been reverted (3e8dc7f47012a5a1e6b8a22f8484ef8e1670fbad)

Actions #17

Updated by ybonatakis almost 5 years ago

https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/7349/ introduces a new variable to solve the problem which the previous one caused.

Actions #18

Updated by mgriessmeier almost 5 years ago

  • Target version changed from Milestone 24 to Milestone 25
Actions #19

Updated by ybonatakis almost 5 years ago

  • Status changed from In Progress to Feedback

Done. Waiting for some VR

Actions #20

Updated by ybonatakis almost 5 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF