action #25724
closedcoordination #25642: [opensuse][sle][y][functional][epic] Set Hostname via DHCP
[opensuse][sle][functional][y][medium] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression)
0%
Description
User story¶
As a user, I want to change the default configuration for DHCLIENT_SET_HOSTNAME on the network configuration step during installation to get an installed system with the value I selected.
Regression¶
- https://bugzilla.suse.com/show_bug.cgi?id=1056633
- https://trello.com/c/Vj69gtYP/1168-5-caasp-20-hostname-via-dhcp-work-according-to-control-file
Acceptance criteria¶
- AC1 The default value for DHCLIENT_SET_HOSTNAME on the network configuration step is preloaded from the control file.
- AC2: The option DHCLIENT_SET_HOSTNAME on the network configuration step is manually changed to another.
- AC3: On the installed system, the value for the network is the selected one.
- AC4: Manually tested for openSUSE, SLES and SLED
- AC5: Automated testing for SLES and SLED
Tasks¶
1. Create a new test suite (and test modules) to cover this scenario.¶
2. Assert the option selected by default on the network configuration step.¶
- NO for openSUSE (see parent epic)
- YES ANY for SLES ? (see parent epic)
- NO for SLED ? (see parent epic)
3. Change the option during the installation with following:¶
- YES for openSUSE (see parent epic)
- NO ANY for SLES ? (see parent epic)
- YES for SLED ? (see parent epic)
4. Assert the configuration on the installed system¶
- openSUSE cat /etc/sysconfig/network/ifcfg-br0 | grep DHCLIENT_SET_HOSTNAME="yes"
- SLES cat /etc/sysconfig/network/dhcp | grep DHCLIENT_SET_HOSTNAME="no"
- SLED cat /etc/sysconfig/network/ifcfg-br0 | grep DHCLIENT_SET_HOSTNAME="yes"
5. Create a test suite entry on O3.¶
6. Create a test suite entry on OSD.¶
Updated by teclator over 6 years ago
The value is DHCLIENT_SET_HOSTNAME, the sethostname option is only for linuxrc.
Updated by SLindoMansilla over 6 years ago
- Subject changed from [opensuse][sle][functional][story] Default value for sethostname preloaded from control file should not overwrite the customer selecction (regression) to [opensuse][sle][functional][story] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selecction (regression)
- Description updated (diff)
Updated by okurz over 6 years ago
- Due date set to 2018-02-27
- Target version set to Milestone 14
Updated by riafarov over 6 years ago
- Subject changed from [opensuse][sle][functional][story] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selecction (regression) to [opensuse][sle][functional][story] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression)
Updated by riafarov over 6 years ago
- Related to action #25650: [opensuse][sle][y][functional][story] Default value for DHCLIENT_SET_HOSTNAME preloaded from linuxrc parameter added
Updated by riafarov over 6 years ago
- Description updated (diff)
- Status changed from New to Workable
Updated by riafarov over 6 years ago
Verify bug manually and move to the next sprint automation of this.
Updated by riafarov over 6 years ago
- Subject changed from [opensuse][sle][functional][story] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression) to [opensuse][sle][functional][story][medium] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression)
Updated by JERiveraMoya about 6 years ago
- Status changed from Workable to In Progress
- Assignee set to JERiveraMoya
Taking a look to tests using Network menu in the installation in order to reuse code/needles, although very likely need to be implemented.
Updated by JERiveraMoya about 6 years ago
We need to take into account this info provided by @teclator:
https://github.com/yast/yast-network/pull/564
https://github.com/yast/yast-installation/pull/612/files
https://github.com/yast/skelcd-control-leanos/blob/master/control/control.leanos.xml#L21
https://github.com/openSUSE/linuxrc/blob/master/linuxrc_hostname.md
Updated by JERiveraMoya about 6 years ago
For openSUSE product there is not simple way to display the Network Configuration screen, as there is no button and the only way is to simulate that is to not have Network. After many attempts using different parameters in the boot options to find a way to temporary boot the system without network, nothing works in a way that we can automate it. The only way that I found is to force it manually when creating a VM, for example, with a wrong bridge. I also thought about to use some qemu parameter but I don't want to disable network the whole test, just for a moment to be able to access this screen. Therefore I removed the [WIP] from the PR with VRs for sle15 and sle12sp4.
Updated by JERiveraMoya about 6 years ago
- Status changed from In Progress to Feedback
Updated by JERiveraMoya about 6 years ago
- Status changed from Feedback to In Progress
Test suite created in OSD and added to the corresponding Development Groups for sle15 and sle12sp4. Waiting for new build to check result.
Updated by JERiveraMoya about 6 years ago
- Status changed from In Progress to Feedback
Updated by JERiveraMoya about 6 years ago
- Status changed from Feedback to Resolved
Added network_configuration test suite to Functional group based on positive results in Development Group: https://openqa.suse.de/tests/1502824
Regarding the ACs:
- openSUSE was not achievable -> Network Configuration has not button in the installer. This screen is only reachable if there is not network. Automation via boot options was not found after talking with the developer and I spent enough time dedicated to openSUSE.
- No difference was found between SLES & SLED or sle15 and sle12sp4, they seems to be consistent in their initial options.
- Added checking of hostname in order to not only verify the setting but also check that the hostname is retrieved from the right source according yast documentation.
Updated by riafarov about 6 years ago
- Due date changed from 2018-02-27 to 2018-03-13
- Status changed from Resolved to In Progress
Please, move test suite to functional job group.
Updated by riafarov about 6 years ago
- Status changed from In Progress to Resolved
Moved to Functional
Updated by okurz about 6 years ago
JERiveraMoya wrote:
- openSUSE was not achievable -> Network Configuration has not button in the installer. This screen is only reachable if there is not network. Automation via boot options was not found after talking with the developer and I spent enough time dedicated to openSUSE.
I think you found something really interesting. I do not think it is a good idea that openSUSE does not offer to change the network configuration at all. IMHO that is an openSUSE bug maybe just because the corresponding screen for egistration is not available in openSUSE. Do you agree and can you create one?
Updated by SLindoMansilla about 6 years ago
- Description updated (diff)
Description updated, waiting for planning meeting to decide how to proceed with this ticket.
Updated by mgriessmeier about 6 years ago
- Subject changed from [opensuse][sle][functional][story][medium] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression) to [opensuse][sle][functional][story][medium][epic] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression)
- Assignee changed from JERiveraMoya to okurz
Updated by JERiveraMoya about 6 years ago
I have time to read it now :) yes I agree 100%, it is functionality that should be there in openSUSE, not just because it is difficult to automate for us. It should be a button for the user.
Updated by okurz about 6 years ago
- Status changed from Workable to In Progress
- Assignee changed from okurz to JERiveraMoya
JERiveraMoya wrote:
I have time to read it now :) yes I agree 100%, it is functionality that should be there in openSUSE, not just because it is difficult to automate for us. It should be a button for the user.
Can you crosscheck older versions of openSUSE, e.g. openSUSE 13.2 or openSUSE Leap 42.1 and check if there was still a button in the installer and create a bug about it?
Updated by JERiveraMoya about 6 years ago
Updated by JERiveraMoya about 6 years ago
- Target version changed from Milestone 14 to Milestone 16
Moved along with the child story: https://progress.opensuse.org/issues/25650
Updated by JERiveraMoya about 6 years ago
- Status changed from In Progress to Workable
Updated by JERiveraMoya about 6 years ago
- Due date changed from 2018-03-13 to 2018-05-15
Updated by okurz about 6 years ago
- Subject changed from [opensuse][sle][functional][story][medium][epic] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression) to [opensuse][sle][functional][y][medium] Default value for DHCLIENT_SET_HOSTNAME preloaded from control file should not overwrite the customer selection (regression)
- Due date changed from 2018-05-15 to 2018-05-22
Correcting due-date to next sprint
Updated by okurz about 6 years ago
- Due date changed from 2018-05-22 to 2018-07-31
- Target version changed from Milestone 16 to Milestone 18
as discussed in sprint planning for S17
Updated by okurz almost 6 years ago
- Target version changed from Milestone 18 to Milestone 18
Updated by JERiveraMoya almost 6 years ago
- Status changed from Workable to In Progress
Resuming work, planning to verify SLED in sle15 and slesp4 as it was the part that was not clear in the review as far as I remember. Still open the bug (see above) for requesting accessibility of Network configuration in openSUSE, so missing part is only SLED.
Updated by JERiveraMoya almost 6 years ago
- Status changed from In Progress to Resolved
Tested with VMs for SLED SP4 and SLE 15 (selecting as a product to install SLED 15)
As expected there is no different between SLES and SLED in sle 15 for that param, the initial value is correct and shared between both and after is changed during installation in the installed system the changed value persists.
For SLED 12 SP4 initially is set to 'no' and after overwrite it to 'yes (any)' successfully persists as well.
Updated by JERiveraMoya almost 6 years ago
Current automation covers only for SLES. For openSUSE we don't have automation as Network is not accessible and for SLED SP4 has been tested manually with VM. Automation does not cover SLED SP4 as it has different default https://github.com/yast/skelcd-control-SLED/blob/master/control/installation.SLED.xml#L38, it makes sense that DHCP is not set as default because is Desktop and imagine that in your own house you have your network and you don't want to use dhcp, you want to assign the ips that you want, so it is specific of the product SLED12 SP4. It was discussed in https://bugzilla.suse.com/show_bug.cgi?id=870896
I am not sure if we should focus on extend automation for SLE 12 SP4 Desktop? as we are not scheduling this test for that product at the moment, not failing any tests. We are only taking into account the case where is 'yes' (which is the right option for server) by default and we change it. Feel free to reopen it if it is strictly necessary to have.
Updated by okurz almost 6 years ago
- Status changed from Resolved to In Progress
riafarov and me are not sure about the status, especially regarding AC4 (openSUSE), let's discuss in the planning meeting
Updated by JERiveraMoya almost 6 years ago
About openSUSE this was the result in comment #16:
JERiveraMoya wrote:
Regarding the ACs:
- openSUSE was not achievable -> Network Configuration has not button in the installer. This screen is only reachable if there is not network. Automation via boot options was not found after talking with the developer and I spent enough time dedicated to openSUSE. ...
At least we figure it out how to get to Network screen and automate it in openSUSE, I was not able to do it at that time.
About the rest of ticket we would need to change current automation to cover SLE12 SP4 Desktop or in other words, the only case where is default 'no'. My only doubt regarding that is if that is our focus, as I normally create automation for sle server mainly for sle15.
I wanted to wrap it out, but yes, let's discusses it in the planning, thanks.
Updated by SLindoMansilla almost 6 years ago
- Description updated (diff)
- Status changed from In Progress to Resolved
openSUSE doesn't show network configuration option when a working network is found. Using a wireless LAN card and not connecting an Ethernet cable, the network step is shown.
But I assume the effort to automate that in openQA, even if possible, is too much. At least we have it covered in SLE.
Updated by okurz almost 6 years ago
Alright, we still have the bug about openSUSE having no access to this network page: https://bugzilla.suse.com/show_bug.cgi?id=1083434