action #17182

clone_job.pl doesn't work without http(s):// in the hostname

Added by pgeorgiadis about 3 years ago. Updated over 1 year ago.

Status:ResolvedStart date:17/02/2017
Priority:NormalDue date:
Assignee:dheidler% Done:

100%

Category:Feature requests
Target version:QA - future
Difficulty:
Duration:

Description

If you do not provide http(s) then you will end up with the following error:

ultron:~ # /usr/share/openqa/script/clone_job.pl --from openqa.opensuse.org --skip-chained-deps --host `hostname -f` -v 356589 TESTDEBUG=1
unexpected return code: 301 Moved Permanently at /usr/share/openqa/script/clone_job.pl line 189.

Workaround, is to use http(s):// in the hostname:

ultron:~ # /usr/share/openqa/script/clone_job.pl --from https://openqa.opensuse.org --skip-chained-deps --host `hostname -f` -v 356589 TESTDEBUG=1

I would like the error message to say something like: please use http(s):// or (better) add the missing http(s):// part automatically in the background.

History

#1 Updated by szarate about 3 years ago

  • Category changed from 122 to 168
  • Status changed from New to Rejected
  • Target version set to future

This is more regarding infrastructure than how jobs are being scheduled.

An excerpt from the documentation shows the following, implicitly explaining how to interact with remote hosts.

clone_job.pl --from https://openqa.opensuse.org --host localhost 24 TESTDEBUG=1 SKIPTO=consoletest-yast2_i

I see no point in adding a check for error codes like this (Because then... you have also 404, 500, and so on), I more value would be in adding a pitfall to express similar situations in the docs.

#2 Updated by coolo about 3 years ago

30X are no errors, they are redirects - and normal HTTP clients follow them. So before you add anything to the docs - rather change the client.

#3 Updated by okurz about 3 years ago

  • Category changed from 168 to Feature requests
  • Status changed from Rejected to New

agreed. client can be improved and also it's good practice to always try https if not forced by the user to not use it.

#4 Updated by dheidler almost 3 years ago

  • Status changed from New to In Progress
  • Assignee set to dheidler

#5 Updated by dheidler almost 3 years ago

  • % Done changed from 0 to 100

PR to simply follow the redirect: https://github.com/os-autoinst/openQA/pull/1258

#6 Updated by dheidler almost 3 years ago

  • Status changed from In Progress to Resolved

merged.

#7 Updated by okurz over 1 year ago

  • Target version changed from future to future

Also available in: Atom PDF