QA (public) » openQA Project (public)

This was a bad idea: it actually breaks some of our tests.

The problem is a bad interaction with assert_and_click , which after it clicks inside the match location, does this:

if (defined $old_mouse_coords->{x} && defined $old_mouse_coords->{y}) {
    return mouse_set($old_mouse_coords->{x}, $old_mouse_coords->{y});
}
else {
    return mouse_hide();
}

The problem is that after this change, $old_mouse_coords->{x} and $old_mouse_coords->{y} are always defined - they're just defined to -1, if the mouse has never been explicitly positioned before the assert_and_click call. So instead of doing mouse_hide() in this case, as it did before, assert_and_click winds up calling mouse_set(-1, -1). I dunno if the behaviour of that is defined in the VNC spec, but what it seems to do in practice at least in qemu is either not move the mouse at all or just move it 1 pixel in each direction (I can't really tell which).

This breaks several of our tests which need to click the same button twice, because the second assert_and_click fails because there's now a mouse cursor sitting on top of the button.

Fix should be pretty simple, I think, just change:

if (defined $old_mouse_coords->{x} && defined $old_mouse_coords->{y})

to:

if ($old_mouse_coords->{x} > -1 && $old_mouse_coords->{y} > -1)

I'll send a PR.

Adam's PR got merged: d8f75d2bc24f63a58545d20b79064a7131d41aa2