Project

General

Profile

Actions
Copy link

action #167914

closed

coordination #127031: [saga][epic] openQA for SUSE customers

coordination #165393: [epic] Improved code coverage in openQA

Improved code coverage in openQA in lib/OpenQA/Worker

Added by okurz about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Low
Assignee:
mkittler
Category:
Feature requests
Target version:
Ready
Start date:
2024-10-08
Due date:
% Done:

0%

Estimated time:

Description

Motivation

To be able to safely improve and extend openQA, we need to have reliable and stable tests with even better code coverage, at least 100% statement coverage. Continue with the path lib/OpenQA/Worker

Acceptance criteria

  • AC1: codecov.yml ensures 100% statement coverage (with explicit Devel::Cover exceptions allowed) for the path lib/OpenQA/Worker in openQA

Suggestions

Related issues 1 (0 open — 1 closed)

Copied from openQA Project - action #165396: Improved code coverage in openQA for unit tests in t/ size:SResolvedmkittler

Actions
Actions
Copy link
 #1

Updated by okurz about 1 month ago

  • Copied from action #165396: Improved code coverage in openQA for unit tests in t/ size:S added
Actions
Copy link
 #2

Updated by mkittler about 1 month ago

  • Status changed from New to In Progress
  • Assignee set to mkittler
Actions
Copy link
 #3

Updated by mkittler about 1 month ago

PR (won't cover everything yet): https://github.com/os-autoinst/openQA/pull/6005

Actions
Copy link
 #4

Updated by livdywan about 1 month ago · Edited

  • Status changed from In Progress to Feedback

PR (won't cover everything yet): https://github.com/os-autoinst/openQA/pull/6005

https://app.codecov.io/gh/os-autoinst/openQA/pull/6005/tree/lib/OpenQA/Worker says 100% so good job!
Can you extend codecov.yml to ensure that we keep 100% so that AC1 of https://progress.opensuse.org/issues/167914#Acceptance-criteria is fulfilled?

Oh, judging by the ACs that's technically really all I have to do for this ticket. I was actually planning on covering Worker.pm as well. I guess I can adjust the threshold for the directory in either case.

PR merged with a follow-up question. Currently it says

      fully_covered:
        target: 100.0
        paths:
          - lib/openQA/Worker`

Is this not enough? 🤔

Actions
Copy link
 #5

Updated by mkittler about 1 month ago

I created https://github.com/os-autoinst/openQA/pull/6014 to also cover the main worker module. This is technically not required by the ACs but I suppose this ticket really had the whole worker code in mind.

Actions
Copy link
 #6

Updated by mkittler about 1 month ago

  • Status changed from Feedback to Resolved

The PR has been merged.

Actions
Copy link

Also available in: Atom PDF