action #164886: Use OpenQA::Git for all our git wrappers size:S - openQA Project (public) - openSUSE Project Management Tool

Custom queries

All 'new' issues w/o assignee, sorted by version/priority
All auto_review tickets
All auto_review+force_result tickets
openQA Infrastructure Project
openqa-review - Closed tickets last updated by openqa-review, last 30 days
QA roadmap long-term
QA SLE functional
QA SLE Functional - closed in last 14 days
QA SLE Functional - High, need to be refined
QA SLE Functional - over cycle time median
QA SLE u
QA SLE y
QA tools (tag not necessary in openQA and subprojects)
QA tools tag (tag not necessary in openQA and subprojects; excluding tickets in "Ready" version as they are already on the backlog)
QAC - Backlog
QE tools team - backlog (dev)
QE tools team - backlog (ready issues)
QE tools team - backlog SLA high
QE tools team - backlog SLA immediate
QE tools team - backlog SLA no immediate/urgent in feedback/blocked
QE tools team - backlog SLA normal
QE tools team - backlog SLA urgent
QE tools team - backlog SLO high
QE tools team - backlog SLO normal
QE tools team - backlog SLO urgent
QE tools team - backlog, high-level view (epics and higher)
QE tools team - backlog, non-reactive work, needs parent
QE tools team - backlog, top-level view (all sagas)
QE tools team - closed within last 14 days
QE tools team - closed within last 60 days
QE tools team - closed yesterday
QE Tools Team - Collaborative Session
QE tools team - due date forecast
QE Tools team - due soon
QE tools team - exceeding due-date
QE tools team - infrastructure backlog
QE tools team - next - sorted by update time
QE tools team - next issues
QE tools team - non-estimated (unblocked) issues (dev)
QE tools team - non-estimated (unblocked) issues (infra)
QE tools team - ready issues - Workable
QE tools team - ready, not assigned/blocked/low
QE tools team - SLO high forecast
QE tools team - update forecast
QE tools team - updated by priority
QE tools team - what members of the team are working on - Feedback (not-low)
QE Tools Team Backlog By Assignee
Tools Team Retrospective
Tools Team Retrospective (not estimated or assigned)

Actions

Copy link

action #164886

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

Use OpenQA::Git for all our git wrappers size:S

Added by tinita 5 months ago. Updated 3 months ago.

Status:

Resolved

Priority:

Normal

Assignee:

robert.richardson

Category:

Feature requests

Target version:

Ready

Start date:

Due date:

% Done:

Estimated time:

Description

Motivation¶

See #162125

https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Git/Clone.pm#L53 uses functions directly defined in the module.
Needle::Save and Needle::Delete are using OpenQA::Git:
https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Save.pm#L9
https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Task/Needle/Delete.pm#L7

Goals¶

AC1: We have one module with all our git wrappers

Suggestions¶

Maybe some code can be reused
Ensure test coverage includes both use cases

Related issues 3 (0 open — 3 closed)

Related to openQA Project (public) - action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:M

Resolved

tinita

Actions

Related to openQA Project (public) - action #165066: Ensure local changes to git repos cloned by git_auto_clone are left alone size:S

Resolved

dheidler

2024-08-08

Actions

Copied from openQA Project (public) - action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:S

Resolved

tinita

2024-06-12

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by tinita 5 months ago

Copied from action #162125: [timeboxed:10h][spike] Let openQA keep test distribution checkouts up to date without needing fetchneedles size:S added

Actions

Copy link

Updated by jbaier_cz 5 months ago

Target version set to Ready

Actions

Copy link

Updated by tinita 5 months ago

Related to action #164898: Replace fetchneedles with a minion job for the regular update of git repos size:M added

Actions

Copy link

Updated by livdywan 4 months ago

Subject changed from Use OpenQA::Git for all our git wrappers to Use OpenQA::Git for all our git wrappers size:S
Description updated (diff)
Status changed from New to Workable

Actions

Copy link

Updated by robert.richardson 4 months ago

Status changed from Workable to In Progress
Assignee set to robert.richardson

Actions

Copy link

Updated by openqa_review 4 months ago

Due date set to 2024-08-27

Setting due date based on mean cycle time of SUSE QE Tools

Actions

Copy link

Updated by tinita 4 months ago

https://github.com/os-autoinst/openQA/pull/5854 Extend test coverage of OpenQA::Git

Actions

Copy link

Updated by robert.richardson 4 months ago

https://github.com/os-autoinst/openQA/pull/5863 Refactor PR turning generic functions of OpenQA::Task::Git:Clone into methods of OpenQA::Git including other minor refactors for the module.

Actions

Copy link

Updated by tinita 4 months ago

https://github.com/os-autoinst/openQA/pull/5863 merged.

We see a failure now:
https://openqa.opensuse.org/tests/4422586#step/test_running/8
https://openqa.opensuse.org/tests/4422583/logfile?filename=test_running-openqa_services.log.txt

Aug 22 06:05:13 susetest openqa-gru[65311]: [info] Running cmd: env GIT_SSH_COMMAND=ssh -oBatchMode=yes git -C /var/lib/openqa/share/tests/example ls-remote --symref https://github.com/os-autoinst/os-autoinst-distri-example.git HEAD
Aug 22 06:05:14 susetest openqa-gru[65311]: [warn] fatal: cannot change to '/var/lib/openqa/share/tests/example': No such file or directory
Aug 22 06:05:14 susetest openqa-gru[65311]: [error] cmd returned 32768

Revert https://github.com/os-autoinst/openQA/pull/5880 was already merged.

I think there are two things that can be improved:

The -C /dir is harmful if we call the ls-remote before the intial clone, so I guess we do need an option to leave out the -C for some commands
The ls-remote is called before the initial clone. But if we don't have the existing clone, we just need to do a clone and never need the ls-remote, and we don't even need the following fetch if we just did a clone, so the code can also be improved in that regard.

Actions

Copy link

#10

Updated by robert.richardson 4 months ago

Status changed from In Progress to Workable

Thank you for the summary. I'll fix everything once i'm back (next wednesday), unless someone else wants to pick it up in the meantime. Setting the ticket back to workable until then.

Actions

Copy link

#11

Updated by tinita 4 months ago

I prepared a PR which improves the order of the git commands and also gets rid of some calls this way: https://github.com/os-autoinst/openQA/pull/5884

The original problem should not appear anymore with your refactoring branch, but still it might make sense to only add -C ... when needed. Not sure yet how that could look like.

Actions

Copy link

#12