action #159747
closedConsolidate openQA related containers size:S
Description
Observation¶
In the os-autoinst/openQA repo there are several Dockerfiles and it seems that only some of them are really used. Only a subset of the definitions is really built in OBS and another subset is documented. Some of them look similar (i.e. openqa_dev vs. openqa_devel) and without clear documentation one could hardly know it they have a similar purpose. This solution is not optimal.
Acceptance criteria¶
AC1: All containers within https://github.com/os-autoinst/openQA/tree/master/container are known, built successfully and documented
AC2: Potential duplicate containers are merged
AC3: There are no unused containers
Suggestions¶
- Lookup all current container definitions in https://github.com/os-autoinst/openQA/tree/master/container as well as https://build.opensuse.org/project/show/devel:openQA and sub-projects
- Try out especially development-related containers
- Ensure documentation is up-to-date in particular for first-time users and contributors
Updated by jbaier_cz 8 months ago
- Related to action #129883: all-in-one openQA container solution added
Updated by jbaier_cz 8 months ago
New containers following openSUSE best practices according to #129958, we should probably prefer those when possible
- openQA/container/single-instance/Dockerfile -> devel:openQA/openQA-single-instance-container
- openQA/container/devel/Dockerfile -> devel:openQA/openQA-devel-container
Container images which are part of containerized setup (and mentioned in docs/ContainerizedSetup.asciidoc):
- openQA/container/openqa_data/Dockerfile -> not build in OBS (does not make sense to build)
- openQA/container/client/Dockerfile -> devel:openQA/openQA_container_client
- openQA/container/webui/Dockerfile -> devel:openQA/openQA_container_webUI
- openQA/container/webui/Dockerfile-lb -> devel:openQA/openQA_container_webUI_loadbalancer
- openQA/container/worker/Dockerfile -> devel:openQA/openQA_container_worker
- openQA/container/worker/Dockerfile.os-autoinst-distri-opensuse -> devel:openQA/openQA_container_worker_os_autoinst_distri_opensuse
Container used in Circle CI:
- openQA/container/devel:openQA:ci/base/Dockerfile -> devel:openQA:ci/base
Unknown usage:
- openQA/container/devel:openQA:ci/dependency_bot/Dockerfile -> devel:openQA:ci/dependency_bot
- openQA/container/ci/Dockerfile -> devel:openQA/openqa_dev
- openQA/container/openqa/Dockerfile -> probably not build in OBS, maybe used locally?
Updated by jbaier_cz 8 months ago
devel:openQA:ci/dependency_bot should be handled by https://build.opensuse.org/request/show/1170800 and https://github.com/os-autoinst/openQA/pull/5603; it might break stuff
Updated by jbaier_cz 8 months ago
openqa_dev (not update Leap 15.1 version, because the path contains containers and not containers15.5) is used to build openqa which is then part of some Makefile targets. Those targets are probably not used anywhere, because they are currently not working anyway (there is a bug introduced 4 year ago in https://github.com/os-autoinst/openQA/pull/3656 where one occurrence of DOCKER_IMG variable was not replaced).
I will look if that can be easily replaced with the new openqa_devel container and change documentation accordingly. Maybe we can drop it entirely, as for CI we already have another container which can be also used locally.
Updated by jbaier_cz 8 months ago
https://github.com/os-autoinst/openQA/pull/5605 is probably the way forward
Updated by openqa_review 8 months ago
- Due date set to 2024-05-14
Setting due date based on mean cycle time of SUSE QE Tools
Updated by jbaier_cz 8 months ago
A little documentation update inside https://github.com/os-autoinst/openQA/pull/5609
Updated by jbaier_cz 8 months ago
And the final bit (which might again break stuff, but shouldn't) is https://github.com/os-autoinst/openQA/pull/5610 and https://build.opensuse.org/request/show/1171373.
Updated by livdywan 8 months ago
- Status changed from In Progress to Feedback
jbaier_cz wrote in #note-10:
And the final bit (which might again break stuff, but shouldn't) is https://github.com/os-autoinst/openQA/pull/5610 and https://build.opensuse.org/request/show/1171373.
Merged and Accepted respectively. Are we good here then?