action #157858
closed
openQA Project - coordination #102915: [saga][epic] Automated classification of failures
coordination #119338: [epic] SLO Automation for openqatests SLOs
Repeated reminder comments about SLO's for openqatests size:S
Added by livdywan about 2 months ago.
Updated 24 days ago.
Description
Motivation¶
#157522 addressed a bug that prevented reminder comments from being sent. Unfortunately comments are added even if a comment was already present. This is especially visible in immediate tickets, for example #153115, which get daily reminders - as per #116545 only one comment is supposed to be added. Maybe this is a regression or the check is not comprehensive enough.
Acceptance criteria¶
- AC1: Reminders are only added once
Suggestions¶
- We already have the code that should handle that: Review the implementation from #116545 for gaps in the current logic in https://github.com/openSUSE/backlogger/blob/main/backlogger.py
- Investigate if something changed with current comments, maybe the Redmine upgrade made a difference here (complete guess)?
- Maybe the regex needs to be adapted and/or better covered with unit testing
- Copied from action #157522: No ticket reminder comments about SLO's for openqatests size:M added
- Related to action #119176: Automated alerts and reminders about SLO's for openqatests size:M added
- Priority changed from High to Normal
Although I kind of like the reminders in #153115 . People should really get it that immediate tickets are not to linger around.
- Subject changed from Repeated reminder comments about SLO's for openqatests size:M to Repeated reminder comments about SLO's for openqatests size:S
- Description updated (diff)
- Status changed from New to Workable
- Status changed from Workable to In Progress
Apparently some issues can't be viewed as JSON. Additionally to the one mentioned I found the following four in our backlog:
I can't see a pattern here yet.
No error message seen in https://github.com/openSUSE/openqa-tests-backlog/actions/runs/8418509129/job/23049150715#step:3:629
curl https://progress.opensuse.org/issues/157360.json
<html><body>You are being <a href="https://progress.opensuse.org/oic/login">redirected</a>.</body></html>
One thing to improve might be to error if we don't get any JSON back.
- Status changed from In Progress to Feedback
- Status changed from Feedback to In Progress
There is no problem with the API, I was just stupid.
I somehow thought just exporting REDMINE_API_KEY did the trick for me, but that is only true for the backlogger script, not for curl.
Also I thought one needs to authenticate for all requests, so I thought authentication was working.
Will remove the according comment from the code again.
- Due date set to 2024-04-09
Setting due date based on mean cycle time of SUSE QE Tools
- Status changed from In Progress to Feedback
Looks like this is not working. Pipelines are consistently failing now:
File "/home/runner/work/openqa-tests-backlog/openqa-tests-backlog/backlogger/backlogger.py", line 101, in reminder_exists
if not "notes" in journal or len(journal["notes"]) == 0:
^^^^^^^^^^^^^^^^^^^^^
TypeError: object of type 'NoneType' has no len()
- Status changed from Feedback to In Progress
Hmm. I think https://github.com/openSUSE/backlogger/pull/34 didn't break it because it didn't change that logic.
It might not have been working before but we didn't see it because the feature wasn't active for very long.
We probably just need to check for journal["notes"] is not None.
- Status changed from In Progress to Feedback
- Status changed from Feedback to Resolved
- Due date deleted (
2024-04-09)
Also available in: Atom
PDF