QA » openQA Project

The line where this happens is:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/main_common.pm#L2575

    load_create_hdd_tests if (get_var("STORE_HDD_1") || get_var("PUBLISH_HDD_1")) && !get_var('PUBLIC_CLOUD');

@rfan1 It is a bit unexpected that a test schedules certain modules depending on a PUBLISH_ variable. Do you think it would make sence to use a different variable for that?
However, there are more occurrences where something like this happens.

@okurz we thought that we could use the presence of the OPENQA_INVESTIGATE_ORIGIN variable for disabling all publishing

tinita wrote in #note-7:

@okurz we thought that we could use the presence of the OPENQA_INVESTIGATE_ORIGIN variable for disabling all publishing

Hm, so where is the removal of publish variables currently done and where would you read OPENQA_INVESTIGATE_ORIGIN to disable publishing? So far I assume only https://github.com/os-autoinst/scripts/ knows about "openqa-investigate", isn't it? What we should sustain is that os-autoinst and openQA do not know about os-autoinst/scripts and shouldn't need to know about it.

tinita wrote in #note-7:

The line where this happens is:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/main_common.pm#L2575

    load_create_hdd_tests if (get_var("STORE_HDD_1") || get_var("PUBLISH_HDD_1")) && !get_var('PUBLIC_CLOUD');

@rfan1 It is a bit unexpected that a test schedules certain modules depending on a PUBLISH_ variable. Do you think it would make sence to use a different variable for that?
Thanks Tina!
IMO, it should be great if we can run the investigation jobs with "PUBLISH_*" to "none".
However, there are more occurrences where something like this happens.

@okurz we thought that we could use the presence of the OPENQA_INVESTIGATE_ORIGIN variable for disabling all publishing

@rfan1 your quoting style is a bit broken marking it hard to distinguish who wrote what.

rfan1 wrote in #note-9:

[…]
IMO, it should be great if we can run the investigation jobs with "PUBLISH_*" to "none".

good idea, we can take a look into that.

However, there are more occurrences where something like this happens.

You mean other test scenarios that also have an incomplete schedule but not related to PUBLISH_*? If yes then please reference those scenarios as well.

@okurz we thought that we could use the presence of the OPENQA_INVESTIGATE_ORIGIN variable for disabling all publishing

Yes, but as I stated what we should sustain is that os-autoinst and openQA do not know about os-autoinst/scripts and shouldn't need to know about it. Meaning that also os-autoinst code must not use the variable OPENQA_INVESTIGATE_ORIGIN.

okurz wrote in #note-10:

However, there are more occurrences where something like this happens.

You mean other test scenarios that also have an incomplete schedule but not related to PUBLISH_*? If yes then please reference those scenarios as well.

That's a quote from me.
I mean that there are other occurrences in the code like loadtest(...) if get_var("PUBLISH_HDD_1")

@rfan1 take care to always add a blank line between quotes and your own text. otherwise redmine reads everything as a quote

tinita wrote in #note-12:

@rfan1 take care to always add a blank line between quotes and your own text. otherwise redmine reads everything as a quote

Got it!

I ran a job with both vars set to none and at least it failed in the same way as the original job: https://openqa.suse.de/tests/13725407#details

I took a look and i read the comments above. is this about modify the https://github.com/os-autoinst/scripts/pull/69/files#diff-f73cf39a07f6cf8cdb453862496919d06df16d07e58b274e68ea148dd1f7dae5R32 to set none or whatever to the script? because from the meeting I thought it has to do something with openQA+os-autoinst

https://github.com/os-autoinst/scripts/pull/299
I guess this is one thing it takes to solve the problem with the scheduling.
Now, it should be something in openQA regarding the upload assets.

I see that on https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Worker/Job.pm#L436 there is a check file. if it is not the whole upload, i think it is skipped. Can someone with more experience confirm that?

ybonatakis wrote in #note-21:

I see that on https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Worker/Job.pm#L436 there is a check file. if it is not the whole upload, i think it is skipped. Can someone with more experience confirm that?

I can confirm that the code silently skips assets specified that can not be uploaded. But I suggest you try it out by simply triggering an openQA job with PUBLISH_HDD_1=none or similar and see what happens.

Action points to try discussed in conversation:

• Clone a job relying on PUBLISH_HDD_1 as-is
  • Also clone the same job with PUBLISH_HDD_1=none
• Make a one-line change in OpenQa/IsoTovideo/Utils.pm in os-autoinst to skip any files called none when compiling the list of assets
• See how 14-isotovideo.t behaves with different asset filenames and trivial changes to the logic

changes on os-autoinst merged. there is still https://github.com/os-autoinst/scripts/pull/299 open