action #15030
closed
highlight actually matched tag in multi-tag needle tag info popup
Added by okurz over 7 years ago.
Updated about 6 years ago.
Category:
Feature requests
Description
User story¶
As a test reviewer, I want the needle tag info popup to show on which tag the best match matched, to better understand multi-tag assert/check_screen calls
acceptance criteria¶
- AC1: For multiple tags the tag of the needle that matched can be distinguished from the other tags
- AC2: No tag is highlighted if there was no match
tasks¶
- research how the match/not-match of needles is stored
- research how the needle tag info popup works in
templates/step/viewimg.html.ep
- for a match, read needle tag of matching needle that matched that is in the list of needle tags that os-autoinst searched for and highlight that one (e.g. bold)
- no highlight for no match
- think and decide about needle tag highlighting when there was no match but a near-match (szarate inspired me for this one when he explained "border cases" to me)
I disagree with this. The plan is to get rid of the current combobox. We need a proper needle list - and merge it with what is in the needle tag list.
The list is supposed to look like this:
Tags:
- yast-is-running
100% yast-is-running-20165010 Needle/Full diff
80% yast-is-running-20141010 Needle/Full diff
- linuxrc-failed
0% linuxrc-failed-20140401 Needle/Full diff
And we show only the '100% yast-is-running-20165010 Needle/Full diff' line by default.
- Related to action #13740: [tools][dashboard] add direct link to where needle was last used added
- Target version set to Ready
- Target version changed from Ready to Current Sprint
I do not understand where your confusion comes from.
Not from your ticket description. Only coolo's comment could have been about the needle editor. At least I thought so in the first place. But after reading it more closely I also understand now that it can't be about the editor.
Maybe some expandable list or customized combo box similar to bootstrap-select then.
- Status changed from New to Feedback
It could look like this: 
@coolo It is still a combo box, but looks similar to the list from your comment. I assume Needle and Full diff should be links. I assume 'Needle' will just show the needle and 'Full diff' the comparison like it is currently the case when clicking on a combo box item.
PR: https://github.com/os-autoinst/openQA/pull/1606
I really want to get rid of the combo box to allow more features added to the needles.
Ok. I would say we can merge the PR nevertheless. It already contains the required modifications needed on the controller side so you can see it as first step to change the view as well.
When changing the view, we can also keep @okurz feature request for copyable entries in mind.
- Related to action #34195: Replace "candidate needles combo box" in test details with popup containing tags/needles added
- Status changed from Feedback to Resolved
- Target version changed from Current Sprint to Done
Also available in: Atom
PDF
