Project

General

Profile

action #15030

highlight actually matched tag in multi-tag needle tag info popup

Added by okurz over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2016-11-25
Due date:
% Done:

0%

Estimated time:
Difficulty:
Duration:

Description

User story

As a test reviewer, I want the needle tag info popup to show on which tag the best match matched, to better understand multi-tag assert/check_screen calls

acceptance criteria

  • AC1: For multiple tags the tag of the needle that matched can be distinguished from the other tags
  • AC2: No tag is highlighted if there was no match

tasks

  • research how the match/not-match of needles is stored
  • research how the needle tag info popup works in templates/step/viewimg.html.ep
  • for a match, read needle tag of matching needle that matched that is in the list of needle tags that os-autoinst searched for and highlight that one (e.g. bold)
  • no highlight for no match
  • think and decide about needle tag highlighting when there was no match but a near-match (szarate inspired me for this one when he explained "border cases" to me)

Related issues

Related to openQA Project - action #13740: [tools][dashboard] add direct link to where needle was last usedResolved2016-09-15

Related to openQA Project - action #34195: Replace "candidate needles combo box" in test details with popup containing tags/needlesResolved2018-04-03

History

#1 Updated by coolo over 3 years ago

I disagree with this. The plan is to get rid of the current combobox. We need a proper needle list - and merge it with what is in the needle tag list.

The list is supposed to look like this:

Tags:
- yast-is-running
  100% yast-is-running-20165010   Needle/Full diff 
  80% yast-is-running-20141010    Needle/Full diff
- linuxrc-failed
  0% linuxrc-failed-20140401      Needle/Full diff

And we show only the '100% yast-is-running-20165010 Needle/Full diff' line by default.

#2 Updated by coolo over 3 years ago

13740 is also related

#3 Updated by okurz over 3 years ago

  • Related to action #13740: [tools][dashboard] add direct link to where needle was last used added

#4 Updated by coolo over 2 years ago

  • Target version set to Ready

#5 Updated by szarate over 2 years ago

  • Target version changed from Ready to Current Sprint

#6 Updated by mkittler over 2 years ago

  • Assignee set to mkittler

#7 Updated by mkittler over 2 years ago

Do you mean the candidates combo box in step and with info button next to it? https://user-images.githubusercontent.com/10248953/37894411-7a782c74-30de-11e8-8534-f27e7a96cf39.png

Or the 'based on' combo box in the needle editor? https://user-images.githubusercontent.com/10248953/37894454-a1d1025a-30de-11e8-9716-91490ad4f286.png

I'm asking because the initial issue description sounds like candidates combo box in step and coolo's idea like 'based on' combo box in the needle editor? It would also make sense to unify both lists.

However, in the step a combobox/popup design makes in my opinion still sense because with the combo box and screenshot are currently already filling all the space. There is no space left for a static, non-popup list (without scrolling).

#8 Updated by okurz over 2 years ago

mkittler wrote:

Do you mean the candidates combo box in step and with info button next to it? https://user-images.githubusercontent.com/10248953/37894411-7a782c74-30de-11e8-8534-f27e7a96cf39.png

^
|
-- this one. I do not understand where your confusion comes from. My ticket description never mentions the word "edit" or "editor" even and the role is "test reviewer", so a "read-only" role. I am taking about the same thing as coolo he was just disagreeing with my implementation proposal.

#9 Updated by mkittler over 2 years ago

I do not understand where your confusion comes from.

Not from your ticket description. Only coolo's comment could have been about the needle editor. At least I thought so in the first place. But after reading it more closely I also understand now that it can't be about the editor.

Maybe some expandable list or customized combo box similar to bootstrap-select then.

#10 Updated by mkittler over 2 years ago

  • Status changed from New to Feedback

It could look like this: candidates grouped by tags

coolo It is still a combo box, but looks similar to the list from your comment. I assume Needle and Full diff should be links. I assume 'Needle' will just show the needle and 'Full diff' the comparison like it is currently the case when clicking on a combo box item.

PR: https://github.com/os-autoinst/openQA/pull/1606

#11 Updated by coolo over 2 years ago

I really want to get rid of the combo box to allow more features added to the needles.

#12 Updated by mkittler over 2 years ago

Ok. I would say we can merge the PR nevertheless. It already contains the required modifications needed on the controller side so you can see it as first step to change the view as well.

When changing the view, we can also keep okurz feature request for copyable entries in mind.

#13 Updated by mkittler over 2 years ago

  • Related to action #34195: Replace "candidate needles combo box" in test details with popup containing tags/needles added

#14 Updated by mkittler over 2 years ago

  • Status changed from Feedback to Resolved

#15 Updated by szarate over 2 years ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF