action #13920

Showing context builds test result in the view of current "Previous Results"

Added by yfjiang over 3 years ago. Updated almost 2 years ago.

Status:ResolvedStart date:27/09/2016
Priority:NormalDue date:
Assignee:mitiao% Done:

0%

Category:Feature requests
Target version:Done
Difficulty:
Duration:

Description

Hi,

This is a feature request.

When reviewing a specific set of test, there's a convenient tab showing
all the previous results:

http://openqa.suse.de/tests/579565#previous

However, it is not seldom we take a test review from the middle of all
results where an issue happens. In that case, both previous and latter
results of the current would make sense. (more like "grep -C"
instead of "grep -A")

So making the tab's view showing the test status of the context builds
will help.


Related issues

Related to openQA Project - action #25814: load job page, e.g. test details, only on demand Workable 06/10/2017
Related to openQA Project - action #36307: Remove limit option in Next & previous results tab UI Resolved 17/05/2018

History

#1 Updated by okurz over 3 years ago

  • Priority changed from Normal to Low

This is planned to do but considered low priority as we have link to latest now. Please take a look for the "latest" feature. It should already provide you "context" by going to the latest and showing the previous ones from there.

#2 Updated by okurz over 2 years ago

  • Related to action #25814: load job page, e.g. test details, only on demand added

#3 Updated by coolo over 2 years ago

  • Priority changed from Low to Normal
  • Target version set to Ready

I need this more often than you might think when debugging a regression

#4 Updated by szarate almost 2 years ago

  • Target version changed from Ready to Current Sprint

#5 Updated by mitiao almost 2 years ago

  • Assignee set to mitiao

#6 Updated by mitiao almost 2 years ago

  • Status changed from New to In Progress

#7 Updated by mitiao almost 2 years ago

wip pr submitted:
https://github.com/os-autoinst/openQA/pull/1614

got feedbacks and re-design the with following:
extend the query to fetch needed data;
lazy loading for the tab;
use datatable to generate table;
and other details...

#8 Updated by mitiao almost 2 years ago

done data query by dbix virtual view and pass object based data for datatable
fetch id by sql with dbh handler and get data by dbix is next to try

datatable rendering part was done half
working on differentiate the last, latter, prev and current job
as well as failed module popup event

#9 Updated by mitiao almost 2 years ago

almost done the functionality with jquery datatable rendering, lazy load "results" tab and new search in tab.
only a issue is failed needle tooltip not applying stylesheet, investigating...
writing unit test and will rebase PR for feedback with current changes..

#10 Updated by mitiao almost 2 years ago

mitiao wrote:

almost done the functionality with jquery datatable rendering, lazy load "results" tab and new search in tab.

only a issue is failed needle tooltip not applying stylesheet, investigating...

writing unit test and will rebase PR for feedback with current changes..

tooltip works now and unit test is still writing.
paste current tab view for feedback:
https://github.com/os-autoinst/openQA/pull/1614#issue-178247252

#11 Updated by mitiao almost 2 years ago

unit tests done and fixed travis checks

#12 Updated by mitiao almost 2 years ago

  • Status changed from In Progress to Resolved

PR merged.

#13 Updated by mitiao almost 2 years ago

  • Related to action #36307: Remove limit option in Next & previous results tab UI added

#14 Updated by okurz almost 2 years ago

  • Status changed from Resolved to In Progress

Please consider my comments from the PR:

  1. there are use cases where I need as many as possible which turned out to be higher than 400 sometimes. So previously I used the URL query parameter. If this is still possible and you do not want to remove that then it's fine.
  2. Also I consider it important to have the address bar of the browser updated so that we can references these links elsewhere, e.g. in bug reports. That seems to have gone broken.
  3. You seem to have removed the "link to latest" and also removed the test for this. Please bring this back. Seems we missed this in the review :(

#15 Updated by coolo almost 2 years ago

  • The URL parameter is gone for good as we lazy load now. Higher than 400 will not be supported - if you want to go deeper, start from the latest of the current set.
  • we don't want to support limit options at all - but have them 'reasonable' without option
  • link to latest could be on the L, which brings us to one more feature: always have the latest as part of the queue.

#16 Updated by coolo almost 2 years ago

  • Status changed from In Progress to Resolved

Sorry, but the ticket is resolved. That it introduced problems, are new problems.

#17 Updated by okurz almost 2 years ago

Sure, if you want to simulate progress by closing more tickets per time…

#18 Updated by szarate almost 2 years ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF