QA (public) » openQA Project (public)

I think we tried symlinks in the past for that and found out that github actions do not support them :-/
Do you have a working setup with symlinks?

I haven't tried symlinks. But GitHub docs offers "Reusable Workflows" 0

I'll set up a simple check on os-autoinst-commons (the commit message one) with what they say in the docs and try to "inherit it" on os-autoinst.

Here's a working minimal example of a reusable workflow:

https://github.com/os-autoinst/os-autoinst-common/pull/28

The limitation is that reusable workflows must be in: /.github/workflows/, no nesting is allowed as per docs.

Other repositories can make references to the reusable workflow as long as they have access to.

Steps forward:

1. [x] Cleanup the Reusable workflow PR 0 to have only the commit messages check.
2. [x] Have it merged.

3. [] Substitute checks in:

   • os-autoinst
   • os-autoinst-distri-opensuse
   • openQA

   with the reusable checks from os-autoinst-common.

If you like you can also create PRs to use the inherited workflow in

• https://github.com/os-autoinst/os-autoinst-distri-openQA/blob/master/.github/workflows/commit_message_checker.yml
• https://github.com/os-autoinst/openqa-logwarn/blob/master/.github/workflows/commit_message_checker.yml

but somebody else can also do that.

https://github.com/os-autoinst/openqa-logwarn/pull/48
https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/152

We are now getting an error in our nightly dependencies update job:
https://app.circleci.com/pipelines/github/os-autoinst/openQA/12400/workflows/7bc41274-bbd1-4145-9a0f-0715f4e9e37f/jobs/115757

[dependency_2023-10-27 d20ce8677] Dependency cron 2023-10-27
 2 files changed, 2 insertions(+), 2 deletions(-)
To https://github.com/os-autoinst-bot/openQA.git
 ! [remote rejected]     dependency_2023-10-27 -> dependency_2023-10-27 (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/commit-message-checker.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/os-autoinst-bot/openQA.git'

Exited with code exit status 1

I looked up the token for the os-autoinst-bot and it does already have the "workflow" scope. So maybe the way the reusable workflow is using the token is wrong...

tinita wrote in #note-9:

https://github.com/os-autoinst/openqa-logwarn/pull/48
https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/152

Thanks for taking care @tinita!

tinita wrote in #note-10:

We are now getting an error in our nightly dependencies update job:
https://app.circleci.com/pipelines/github/os-autoinst/openQA/12400/workflows/7bc41274-bbd1-4145-9a0f-0715f4e9e37f/jobs/115757

[dependency_2023-10-27 d20ce8677] Dependency cron 2023-10-27
 2 files changed, 2 insertions(+), 2 deletions(-)
To https://github.com/os-autoinst-bot/openQA.git
 ! [remote rejected]     dependency_2023-10-27 -> dependency_2023-10-27 (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/commit-message-checker.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/os-autoinst-bot/openQA.git'

Exited with code exit status 1

I think it prohibited for automation to create .github workflow files, I'll investigate.

I was looking at the wrong token. I now added the "workflow scope" to the right one and reran the job. All fine now :)

livdywan wrote in #note-24:

The ticket doesn't look to me like it's actively being worked on or would be done this week. Since someone outside the Tools team is assigned to it, though, we should not have it on the backlog as we can't require others to meet our expectations.

Is not clear to me where to drive the discussion. Here there are unanswered questions and in the PR's there are also unanswered questions. Please advise for an appropriate place and I'll follow through.

As per feedback from @okurz, I've splitted os-autoinst/os-autoinst-commons#30 in two isolated PR's #31 & #32. Hopefully that can make reviews easier.

Additionally, the example distribution also gets some love for the simplification area:

• os-autoinst/os-autoinst-distri-example#28 makes the workflow definition easier to read and brings pipeline artifacts for later inspection.

Let's focus on the discussions in the open pull requests

Following the discussion on standup today:

• I'll add a PR in os-autoinst to either:
  • provide the suggested scripts/validate-test-results from os-autoinst/os-autoinst-distri-example#28
  • allow isotoviodeo to reflect the test result in the exit code. Something along the lines of isotovideo [...] --exit-status-from-error.

whatever of the two is less effort.

• Add a comment to explain what Mojo::Base means in openQA tests.

• More native GitHub Action definition in the example.

• Add another PR for use warnings/stricts in the examples where Mojo::Base does not apply.

• Reduced os-autoinst/os-autoinst-distri-example#28 to pull the commit checker

Another PR: Make isotovideo exit code reflect test module result

https://github.com/os-autoinst/os-autoinst/pull/2419 merged

Currently making several subrepo update PRs, using the new common config files where possible

I am a bit confused with it and looks more complicated than I initially thought.
I started with what looks to work immediately, starting with os-autoinst
[0] replace the .perlcriticrc and .yamllint
diff of .perlcriticrc[1] is significant but seems to work

[0] https://github.com/os-autoinst/os-autoinst/pull/2451
[1] https://gist.github.com/b10n1k/5825121257899cb3f85cfd0463266dae

Before link the .perlcriticrc from os-autoinst-common is better to apply the changes sequentially per rule.
Some rules are under discussion

• https://suse.slack.com/archives/C02AJ1E568M/p1706805133571569
• https://suse.slack.com/archives/C02AJ1E568M/p1706805214484479
• https://suse.slack.com/archives/C02AJ1E568M/p1706805314954719
• https://suse.slack.com/archives/C02AJ1E568M/p1706805376502689

The following PR is all about interpolation strings(Useless interpolation of literal string) and some Hash key with quotes
https://github.com/os-autoinst/openQA/pull/5448
quite big but really simple

Another one for no critic annotation https://github.com/os-autoinst/openQA/pull/5449

Created https://github.com/os-autoinst/openQA/pull/5450 as followup refactoring to fix deeply nested loops. I would like to review this before peer reviews as i think it can be a little better.

https://github.com/os-autoinst/openQA/pull/5453 was last touch on OpenQA.
All merged so ..last part before switch to the perlcritic from the os-autoinst-common is one small adjustment regarding useless quotes in hashes
https://github.com/os-autoinst/os-autoinst-common/pull/40

https://github.com/os-autoinst/openQA/pull/5459 last PR for openQA. https://github.com/os-autoinst/openQA/pull/5457 has to merged first after https://github.com/os-autoinst/os-autoinst-common/pull/45/files :(
turn focus to os-autoinst-distri-example

As we agree, we want just to enable checks from common repo on os-autoinst-distri-example.
https://github.com/os-autoinst/os-autoinst-distri-example/pull/31 enables yamllint, tidy and perlcritic.

overall, openQA uses the common perlcritic, os-autoinst yamllint and perlcritic and finally yamllint, tidy and perlcritic for os-autoinst-distri-example

ybonatakis wrote in #note-46:

https://github.com/os-autoinst/os-autoinst-distri-example/pull/31 contains commit which fixes also isotovideo tests

Seems I have to split all the commits. here is the first https://progress.opensuse.org/issues/138416#note-46 cloning the common repo

ybonatakis wrote in #note-47:

ybonatakis wrote in #note-46:

https://github.com/os-autoinst/os-autoinst-distri-example/pull/31 contains commit which fixes also isotovideo tests

Seems I have to split all the commits. here is the first https://progress.opensuse.org/issues/138416#note-46 cloning the common repo

fixing the pipeline https://github.com/os-autoinst/os-autoinst-distri-example/pull/33

pipeline fixed by another PR by Oliver.
this ticket is almost ready. problem is that we split the initial commit in smaller parts. Give it a couple of days