Project

General

Profile

Actions

action #136244

closed

Ensure arbitrary comments can be taken over to new jobs size:M

Added by okurz 9 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Feature requests
Target version:
Start date:
2023-09-21
Due date:
2023-11-17
% Done:

0%

Estimated time:

Description

Motivation

#107923-64 states that carry-over of @review:acceptable_for… comments do not work which is expected because such comments are just "openQA comments", in openQA only bugrefs are carried over.

#107923-71 might provide valid points that should be crosschecked but effectively no one will be able to find those suggestions again buried in a ticket. Let's make the suggestions more prominent.

For example

@review:acceptable_for:incident_30146:bsc#1212271

bsc#1212271

Or

@review:acceptable_for:incident_30146:.

bsc#1212271

Note the bugref to trigger takeover.

Acceptance criteria

  • AC1: Valid workflows from #107923-71 are covered in public upstream help text or documentation
  • AC2: Arbitrary comments can be taken over with a known syntax, e.g. combined with bugref
  • AC3: Plain comments without bugrefs are not taken over

Suggestions

  • See #107923-71
  • Research what this feature is, where it's implemented and how it works
  • Check if the ideas are valid and work as stated
  • Correct where needed
  • Optional: Improvements to help text within openQA comment editor
  • Add to upstream openQA documentation
  • Optional: Spread the ideas more, e.g. workshop

Related issues 2 (0 open2 closed)

Related to QA - action #107923: qem-bot: Ignore not-ok openQA jobs for specific incident based on openQA job comment size:MResolvedjbaier_cz

Actions
Related to openQA Project - action #139055: Comments mentioning bugrefs as part of a sentence are treated like bug refs and taken over size:SResolvedokurz2023-10-272023-11-17

Actions
Actions #1

Updated by okurz 8 months ago

  • Target version changed from Tools - Next to Ready
Actions #2

Updated by livdywan 8 months ago

  • Subject changed from Ensure ideas from #107923-71 are reachable from open.qa/docs to Ensure arbitrary comments can be taken over to new jobs size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by livdywan 8 months ago

  • Related to action #107923: qem-bot: Ignore not-ok openQA jobs for specific incident based on openQA job comment size:M added
Actions #4

Updated by dheidler 8 months ago

  • Assignee set to dheidler
Actions #5

Updated by dheidler 8 months ago

  • Status changed from Workable to In Progress
Actions #6

Updated by openqa_review 8 months ago

  • Due date set to 2023-11-14

Setting due date based on mean cycle time of SUSE QE Tools

Actions #7

Updated by livdywan 7 months ago

  • Related to action #139055: Comments mentioning bugrefs as part of a sentence are treated like bug refs and taken over size:S added
Actions #9

Updated by livdywan 7 months ago

  • Due date changed from 2023-11-14 to 2023-11-17

Not expecting this to be worked on this week, hence bumping the due date

Actions #11

Updated by dheidler 7 months ago

  • Status changed from In Progress to Feedback

Let's see if it will look fine after next deployment.

Actions #12

Updated by okurz 7 months ago

Already deployed, see https://openqa.opensuse.org/changelog , ready to verify :)

Actions #13

Updated by dheidler 7 months ago

  • Status changed from Feedback to Resolved

Looks good so far.
Opened https://github.com/os-autoinst/openQA/pull/5368 for some minor styling improvements.

Actions

Also available in: Atom PDF