Project

General

Profile

Actions
Copy link

action #131204

closed

openqa-trigger-bisect-jobs is called on passed jobs size:M

Added by tinita over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
dheidler
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2023-06-21
Due date:
2023-07-04
% Done:

0%

Estimated time:

Description

Observation

From o3 accesslogs it seems that a python script is requesting /tests/.../investigation_ajax urls. Some of those jobs are passed.
User-Agent is python-requests/2.24.0.
It looks like it is openqa-trigger-bisect-jobs. Might be an oversight from when we changed the hook script to also be called on passed retry jobs.

Example job for which the url was requested: https://openqa.opensuse.org/tests/3369622

Acceptance Criteria

  • AC1: there are no unnecessary actions triggered in openQA for passed jobs by openqa-trigger-bisect-jobs
  • AC2: openqa-trigger-bisect-jobs sets a proper user agent header for all its requests

Suggestions

  • Add a proper user agent header for all the requests of openqa-trigger-bisect-jobs
  • Does it even make sense for investigation_ajax to return something for a passed job? Maybe return early in this case
  • let openqa-trigger-bisect-jobs check if the job actually passed and return in this case without doing anything
  • Crosscheck openqa-label-known-issues-and-investigate-hook and openqa-trigger-bisect-jobs of https://github.com/os-autoinst/scripts/ if it makes sense to actually call the investigate route on openQA
  • look at the openQA webUI configuration where hooks are enabled, for o3 check on o3 locally in /etc/openqa/openqa.ini

Further details

openqa-trigger-bisect-jobs can not work properly right now anyway because the SUSE QE squad QE-Core changed the test definitions to install incident packages in image creation jobs so likely not the downstream jobs that would fail and trigger openqa-trigger-bisect-jobs anyway. See #122296 for that

Related issues 2 (1 open — 1 closed)

Related to openQA Project (public) - action #122296: Fix openqa-trigger-bisect-jobs to actually remove incidents from bisection tests againNewszarate2024-02-13

Actions
Related to openQA Project (public) - action #131486: Fix comment posting in openqa-trigger-bisect-jobsResolvedmkittler2023-06-27

Actions
Actions
Copy link
 #1

Updated by tinita over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by okurz over 1 year ago

  • Target version set to Ready

tinita wrote:

  • Does it even make sense for investigation_ajax to return something for a passed job? Maybe return early in this case

I think somebody recently requested that we show the "investigation" button also on passed jobs. But I don't recall what they expected to see there. I guess it can still make sense for some use case.

Actions
Copy link
 #3

Updated by tinita over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by dheidler over 1 year ago

  • Subject changed from openqa-trigger-bisect-jobs is called on passed jobs to openqa-trigger-bisect-jobs is called on passed jobs size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by okurz over 1 year ago

  • Related to action #122296: Fix openqa-trigger-bisect-jobs to actually remove incidents from bisection tests again added
Actions
Copy link
 #6

Updated by okurz over 1 year ago

  • Description updated (diff)
Actions
Copy link
 #7

Updated by dheidler over 1 year ago

  • Assignee set to dheidler
Actions
Copy link
 #8

Updated by dheidler over 1 year ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #9

Updated by dheidler over 1 year ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #10

Updated by dheidler over 1 year ago

  • Status changed from Feedback to Resolved
Actions
Copy link
 #11

Updated by okurz over 1 year ago

  • Due date set to 2023-07-04
  • Status changed from Resolved to Feedback

please provide a verification from production where we can see that openqa-trigger-bisect-jobs still works as expected

Actions
Copy link
 #12

Updated by okurz over 1 year ago

  • Related to action #131486: Fix comment posting in openqa-trigger-bisect-jobs added
Actions
Copy link
 #13

Updated by okurz over 1 year ago

Discussed in unblock. After https://github.com/os-autoinst/scripts/pull/237 merged please check again that openqa-trigger-bisect-jobs does what it should, i.e. write helpful comments on unreviewed jobs on both o3+osd (I guess?) and helps openQA test reviewers. E.g. call https://openqa.opensuse.org/tests?match=bisect and look at those jobs and the original investigation target jobs if it posts a useful comment there.

Actions
Copy link
 #14

Updated by dheidler over 1 year ago

  • Status changed from Feedback to Resolved

Failed job: https://openqa.suse.de/tests/11467948#comments

10.100.96.72 - - [28/Jun/2023:09:34:22 +0200] "POST /api/v1/jobs/11467948/status HTTP/1.1" 200 2916 "-" "Mojolicious (Perl)" 9607
10.100.96.72 - - [28/Jun/2023:09:34:31 +0200] "POST /api/v1/jobs/11467948/set_done?worker_id=2292 HTTP/1.1" 200 33 "-" "Mojolicious (Perl)" 441
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:05:35 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 165
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:05:40 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "openqa-label-known-issues (https://github.com/os-autoinst/scripts)" 101
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:05:43 +0200] "GET /tests/11467948/file/autoinst-log.txt HTTP/1.1" 200 1023719 "-" "openqa-label-known-issues" 108
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:05:58 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 104
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:02 +0200] "GET /tests/11467948/dependencies_ajax HTTP/1.1" 200 254 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 44
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:08 +0200] "POST /api/v1/jobs/11467948/comments HTTP/1.1" 200 13 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 101
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:11 +0200] "GET /api/v1/jobs/11467948/comments HTTP/1.1" 200 247 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 96
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:16 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 96
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:23 +0200] "GET /tests/11467948/investigation_ajax HTTP/1.1" 200 20607 "-" "openqa-investigate" 586
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:06:35 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 161
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:19 +0200] "PUT /api/v1/jobs/11467948/comments/869811 HTTP/1.1" 200 13 "-" "openqa-investigate (https://github.com/os-autoinst/scripts)" 126
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:21 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 107
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:21 +0200] "GET /tests/11467948/investigation_ajax HTTP/1.1" 200 2117 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 504
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:23 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 50
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:31 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 334
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:37 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 162
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:46 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 177
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:52 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 106
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:07:59 +0200] "GET /api/v1/jobs/11467948 HTTP/1.1" 200 1584 "-" "Mojolicious (Perl)" 270
2620:113:80c0:8080:10:160:0:207 - - [28/Jun/2023:16:08:10 +0200] "POST /api/v1/jobs/11467948/comments HTTP/1.1" 200 13 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 201
2620:113:80c0:8360::1061 - - [28/Jun/2023:17:11:41 +0200] "GET /tests/11467948 HTTP/1.1" 200 9033 "https://openqa.suse.de/tests/11470003" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, lik

Passed jobs:

2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:54:12 +0200] "GET /api/v1/jobs/11475090 HTTP/1.1" 200 1157 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 72
2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:54:12 +0200] "GET /tests/11475090/investigation_ajax HTTP/1.1" 200 1096 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 378
2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:55:25 +0200] "GET /api/v1/jobs/11474954 HTTP/1.1" 200 1705 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 39
2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:55:51 +0200] "GET /api/v1/jobs/11475040 HTTP/1.1" 200 1206 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 64
2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:58:27 +0200] "GET /api/v1/jobs/11474965 HTTP/1.1" 200 1709 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 41
2620:113:80c0:8080:10:160:0:207 - - [29/Jun/2023:13:59:32 +0200] "GET /api/v1/jobs/11474906 HTTP/1.1" 200 1695 "-" "openqa-trigger-bisect-jobs (https://github.com/os-autoinst/scripts)" 41
Actions
Copy link

Also available in: Atom PDF