Project

General

Profile

action #131204

Updated by dheidler over 1 year ago

## Observation 

 From o3 accesslogs it seems that a python script is requesting `/tests/.../investigation_ajax` urls. Some of those jobs are passed. 
 User-Agent is `python-requests/2.24.0`. 
 It looks like it is `openqa-trigger-bisect-jobs`. Might be an oversight from when we changed the hook script to also be called on passed retry jobs. 

 Example job for which the url was requested: https://openqa.opensuse.org/tests/3369622 

 ## Acceptance Criteria 

 * **AC1:** there are no unnecessary actions triggered in openQA for passed openqa-trigger-bisect-jobs is only called on failed jobs by openqa-trigger-bisect-jobs 
 * **AC2:** openqa-trigger-bisect-jobs sets a proper user agent header for all its requests 

 ## Suggestions 
 * Add a proper user agent header for all the requests of openqa-trigger-bisect-jobs 
 * Does it even make sense for `investigation_ajax` to return something for a passed job? Maybe return early in this case 
 * let openqa-trigger-bisect-jobs check if the job actually passed and return in this case without doing anything 
 * Crosscheck openqa-label-known-issues-and-investigate-hook *and* openqa-trigger-bisect-jobs of https://github.com/os-autoinst/scripts/ if it makes sense to actually call the investigate route on openQA 
 * look at the openQA webUI configuration where hooks are enabled, for o3 check on o3 locally in /etc/openqa/openqa.ini 

 ## Further details 
 openqa-trigger-bisect-jobs can not work properly right now anyway because the SUSE QE squad QE-Core changed the test definitions to install incident packages in image creation jobs so likely not the downstream jobs that would fail and trigger openqa-trigger-bisect-jobs anyway

Back