action #126590: [qe-core] loading tests in Python is broken when using YAML - openQA Tests (public) - openSUSE Project Management Tool

Actions

Copy link

action #126590

closed

[qe-core] loading tests in Python is broken when using YAML

Added by szarate about 2 years ago. Updated about 2 years ago.

Status:

Resolved

Priority:

High

Assignee:

mgrifalconi

Category:

Bugs in existing tests

Target version:

QA (public) - QE-Core: Ready

Start date:

2023-03-24

Due date:

% Done:

100%

Estimated time:

Difficulty:

Sprint:

QE-Core: April Sprint 23 (Apr 05 - May 03)

Tags:

qe-core-april-sprint, qe-core-march-sprint, platform-team, qaaas

Description

TL;DR, we need to know whether it's a PM or a Python test:

What we are missing here is first to check whether the file is perl or python, if the file exists then load it

https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/e1214f966566deac2b7910ab3733ad6debb9a989/lib/main_common.pm#L139

sub loadtest {
    my ($test, %args) = @_;
    croak "extensions are not allowed here '$test'" if $test =~ /\.pm$/;
    autotest::loadtest("tests/$test.pm", %args);
}

Related issues 3 (1 open — 2 closed)

Actions

Copy link

Updated by szarate about 2 years ago

Related to action #109891: [qe-core] Writing openQA tests with python added

Actions

Copy link

Updated by szarate about 2 years ago

Description updated (diff)
Status changed from New to Workable
Assignee deleted (~~szarate~~)

Actions

Copy link

Updated by szarate about 2 years ago

Priority changed from Normal to High

Actions

Copy link

Updated by szarate about 2 years ago

Sprint set to QE-Core: March Sprint (Mar 08 - Apr 05)
Tags changed from platform-team, qaaas to platform-team, qaaas, qe-core-march-sprint

Actions

Copy link

Updated by szarate about 2 years ago

Related to coordination #127031: [saga][epic] openQA for SUSE customers added

Actions

Copy link

Updated by okurz about 2 years ago

@szarate as this issue came up today some points:

This is only about os-autoinst-distri-opensuse right?
Why not track this ticket in a public tracker?
https://github.com/os-autoinst/os-autoinst/blob/master/autotest.pm#L96 supports reading python modules just fine so I guess you can just simplify the call in os-autoinst-distri-opensuse

Actions

Copy link

Updated by szarate about 2 years ago

Project changed from 46 to openQA Tests (public)
Category changed from Bugs in existing tests to Bugs in existing tests

okurz wrote:

@szarate as this issue came up today some points:

This is only about os-autoinst-distri-opensuse right?

Why not track this ticket in a public tracker?

https://github.com/os-autoinst/os-autoinst/blob/master/autotest.pm#L96 supports reading python modules just fine so I guess you can just simplify the call in os-autoinst-distri-opensuse

Yes, this is explicitly about YAML schedules and how the test distri loads modules.

Actions

Copy link