action #124961
closedopenQA restarts user_cancelled jobs with RETRY=N (N>0) size:M
Description
Observation¶
When cancelling a job with RETRY=1
(or any number larger than 0), openQA automatically restarts the job. This is expected for any failed state, but not for cancellation
Acceptance criteria¶
- AC1*: Jobs cancelled by users are not restarted automatically (even when
RETRY
is used). What happens to other cancelled jobs may still remain undefined/suboptimal.
Out of scope¶
- Fixing the mess you can see in #110458
Steps to reproduce¶
- Create job with
RETRY=1
- Cancel the job
Impact / problem¶
When cancelling jobs with RETRY
, we need to cancel N jobs.
Notes¶
- https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Schema/Result/Jobs.pm#L1999
$self->auto_duplicate if $restart || (!$self->is_ok && $self->handle_retry);
- https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Schema/Result/Jobs.pm#L560
sub is_ok ($self) { return 0 unless my $result = $self->result; return 1 if grep { $_ eq $result } OK_RESULTS; return 0; }
- https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Jobs/Constants.pm#L76
use constant OK_RESULTS => (PASSED, SOFTFAILED);
Updated by livdywan almost 2 years ago
- Category set to Regressions/Crashes
- Target version set to Ready
Thank you for reporting this, Felix!
I could be wrong, but I would take this to be a regression. And even if it's not, it would be an issue whenever RETRY is being used. And since we encourage RETRY to be used in many cases, I think this is something we should really look into. And maybe not even that difficult to fix.
Updated by mkittler almost 2 years ago
- Subject changed from openQA restarts user_cancelled jobs with RETRY=N (N>0) to openQA restarts user_cancelled jobs with RETRY=N (N>0) size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by jbaier_cz almost 2 years ago
- Status changed from Workable to In Progress
- Assignee set to jbaier_cz
Updated by jbaier_cz almost 2 years ago
https://github.com/os-autoinst/openQA/pull/5021 should make USER_CANCELLED jobs ok regarding the RETRY
Updated by jbaier_cz almost 2 years ago
- Status changed from In Progress to Feedback
Updated by jbaier_cz almost 2 years ago
- Status changed from Feedback to Resolved
With https://github.com/os-autoinst/openQA/pull/5024 also merged, we can consider this resolved.