Project

General

Profile

action #12180

[webui] Prevent tests to be triggered when required assets are not present (anymore)

Added by sebchlad about 4 years ago. Updated 6 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
2016-05-31
Due date:
% Done:

0%

Estimated time:
Difficulty:
Duration:

Description

User story

As a unaware user of the webui I do not want to be confused by incomplete tests to save time and not annoy developers learning about the issues.

acceptance criteria

  • AC1: Clicking restart button of a job where the required assets do not exist anymore is not possible with a notice to the user about the reason

tasks

  • first probably we need to define what "required assets" mean
  • check existance of required asset on retrieving job details
  • integrate into webUI (user notice preventing retrigger)
  • integrate into API (return error)

further details

original content: Once of the openQA tests was triggered despite missing asset.


Related issues

Related to openQA Project - action #13230: Job cloned with clone_job.pl on a job where the assets already got pruned fails because no assets are downloadedRejected2016-08-17

Related to openQA Project - action #2440: new_iso crashes if there are update tests referring to non existant HDDsResolved2014-05-06

Related to openQA Project - action #34783: Don't let jobs incomplete if mandatory resources are missingResolved2018-04-12

Related to openQA Project - action #28328: job was triggered trying to download HDD image but it's already goneRejected2017-11-24

Related to openQA Project - action #46742: test incompletes trying to revert to qemu snapshot auto_review:"Could not open backing file: Could not open .*.qcow.*No such file or directory", likely premature deletion of files from cacheResolved2019-01-282020-02-18

Related to openQA Project - action #64544: Asset required by scheduled job wiped by limit_assetsRejected2020-03-17

Has duplicate openQA Project - action #23646: Do not allow through the webui to restart a job if the assets were already cleaned up (very old jobs)Rejected2017-08-25

Blocks openQA Project - action #42452: openQA-in-openQA test fails in openqa_webui trying to access a TW snapshot repo on o3 that is already deleted and the test does not track the repoBlocked2018-10-14

History

#1 Updated by okurz almost 4 years ago

  • Assignee deleted (sebchlad)

#2 Updated by okurz over 3 years ago

  • Related to action #13230: Job cloned with clone_job.pl on a job where the assets already got pruned fails because no assets are downloaded added

#3 Updated by okurz over 3 years ago

  • Subject changed from Test being executed while some assets are missing/not sync to Prevent tests to be triggered when required assets are not present (anymore)
  • Description updated (diff)
  • Category set to 122
  • Priority changed from Normal to Low
  • Target version set to future

#4 Updated by okurz over 3 years ago

  • Related to action #2440: new_iso crashes if there are update tests referring to non existant HDDs added

#5 Updated by okurz almost 3 years ago

  • Has duplicate action #23646: Do not allow through the webui to restart a job if the assets were already cleaned up (very old jobs) added

#6 Updated by okurz about 2 years ago

  • Target version changed from future to future

#7 Updated by okurz over 1 year ago

  • Related to action #34783: Don't let jobs incomplete if mandatory resources are missing added

#8 Updated by okurz about 1 year ago

  • Subject changed from Prevent tests to be triggered when required assets are not present (anymore) to [webui] Prevent tests to be triggered when required assets are not present (anymore)
  • Category changed from 122 to Feature requests

#9 Updated by okurz 11 months ago

https://openqa.suse.de/tests/3320973 is a more severe case of a job that had been scheduled automatically (so not a user restarting it manually). At the time the job had a chance to run the asset was already removed (osd:/var/log/openqa states "[2019-09-04T06:35:23.0481 CEST] [info] Removing asset hdd/sle-12-SP5-ppc64le-Build0303-Server-DVD@ppc64le-gnome-encrypted.qcow2 (assigned to groups: 142)")

#10 Updated by okurz 9 months ago

  • Related to action #28328: job was triggered trying to download HDD image but it's already gone added

#11 Updated by okurz 9 months ago

  • Blocks action #42452: openQA-in-openQA test fails in openqa_webui trying to access a TW snapshot repo on o3 that is already deleted and the test does not track the repo added

#12 Updated by okurz 8 months ago

  • Related to action #46742: test incompletes trying to revert to qemu snapshot auto_review:"Could not open backing file: Could not open .*.qcow.*No such file or directory", likely premature deletion of files from cache added

#13 Updated by okurz 6 months ago

mkittler and me tried to come up with ideas as mkittler was already working in a "neighboring code area". Our idea was in the "job_restart" API method to check for the asset existance which we can do simply with methods that the job ResultSet object already has plus utility functions, e.g. lib/OpenQA/Utils.pm:locate_asset like die 'Missing asset ' . $self->name . "\n" unless locate_asset($self->asset->type, $self->asset->name, mustexist => 1) in the low-level function and in the high-level API function catch the exception and return {error => $msg} which is already handled by javascript to show a flash message when someone tries to trigger the job.

What I thought about initial triggering, not cloning, is that we could set the jobs to cancel by checking for asset existance even before asking any workers to pick them up.

#14 Updated by okurz 4 months ago

  • Related to action #64544: Asset required by scheduled job wiped by limit_assets added

Also available in: Atom PDF