Actions
action #114878
closedisotovideo: Add option to disable color output size:S
Description
Actions
Added by tinita over 2 years ago. Updated over 2 years ago.
Description
Should be easy to do although I'm wondering why setting the env variable isn't sufficient.
Because nobody will find the environment variable but if command --help states it then it will be used :)
I will try to work on this during today's workshop day
Setting due date based on mean cycle time of SUSE QE Tools
isotovideo implicitly supports ANSI_COLORS_DISABLED and NO_COLOR. We can actually use this opportunity to document it, in addition to implementing a command-line switch.
After discussing it in the unblock we decided to omit the "auto" option for now and @okurz already proposed a branch with just --color=yes|no support which doesn't require openQA changes. It was bugging me that we couldn't sort out the tests but I'll leave the drafts, and we can re-visit them later.
cdywan wrote:
My branch has retroactively become the follow-up branch for color=auto which needs to use IO::Interactive to make it unit-testable. The AC's are fulfilled so the ticket isn't dependent on this being merged.
I agree that the AC's are covered. So I suggest you decide between the following alternatives:
I'm resolving the ticket because it looks like unit testing is not trivial afterall and that feels like it's dragging on too much.
Enabling and disabling colors via --color=yes and --color=no meanwhile to work nicely.