action #11446

Feature 318144: Btrfs quota group improvements

Added by maritawerner about 4 years ago. Updated over 3 years ago.

Status:ResolvedStart date:01/04/2016
Priority:UrgentDue date:
Assignee:mkravec% Done:

100%

Category:-
Target version:openQA Project - Milestone 3
Difficulty:
Duration:

Description

For details see https://fate.suse.com/318144

First check if the Feature status is "done".

I propose that I improve the implementation of btrfs quota groups beyond what we had for SLES-12 GA. The benefits to this work would be that snapper and our end users would get improved accounting of space usage on btrfs. In addition I list a few items which are intended to generally improve the quality of btrfs quota groups.

Specifically:

Kernel Tasks:

  • Implement hierarchical quota groups. This way snapper could create parent groups which account properly for the groups below them. This may have a performance impact on quota rescan though.

  • Delete qgroup items on subvolume deletion (I wanted this for us earlier but it turned out to be more complicated than initially thought)

Btrfsprogs:

  • Accounting of heirarchical groups in btrfsck (right now btrfsck only cares about level 0 groups)

  • btrfsck to write out fixed qgroup items. This prevents user from having to do a rescan on unclean shutdown.


Related issues

Copied to openQA Tests - action #13974: btrfs_qgroups tests unstable (on o3) Rejected 01/04/2016

History

#1 Updated by RBrownSUSE almost 4 years ago

  • Target version set to 168

#2 Updated by okurz almost 4 years ago

  • Target version changed from 168 to Milestone 3

#3 Updated by RBrownSUSE over 3 years ago

  • Priority changed from Normal to Urgent

#4 Updated by mkravec over 3 years ago

  • Status changed from New to In Progress
  • Assignee set to mkravec

#6 Updated by maritawerner over 3 years ago

Hi,

I am out of office untill August, 14, my back-up is Sebastian Chlad schlad@suse.com

Best regards,

Marita Werner

#7 Updated by mkravec over 3 years ago

#8 Updated by okurz over 3 years ago

works fine in production on sles+extratests on x86_64: https://openqa.suse.de/tests/502327#step/btrfs_qgroups/25
fails on ppc64le: https://openqa.suse.de/tests/502327#step/btrfs_qgroups/25

Please check

#9 Updated by mkravec over 3 years ago

This fail seems quite strange, test does this:
1. btrfs qgroup limit 50m a
2. for c in {1..40}; do dd if=/dev/zero bs=1M count=1 of=a/file\$c; done
and fails to write at 34M on ppc64le.

I will check with btrfs people tomorrow, or maybe someone with ppc knowledge can explain.

#10 Updated by RBrownSUSE over 3 years ago

please file a bug regarding the qgroups issue on ppc64le

#11 Updated by mkravec over 3 years ago

  • Status changed from In Progress to Feedback

Block size is different on ppc and x86_64. Test needs to be updated to take this into account.

Test should also contain check for:
https://bugzilla.suse.com/show_bug.cgi?id=993841

#12 Updated by mkravec over 3 years ago

  • Status changed from Feedback to In Progress

#13 Updated by mkravec over 3 years ago

#14 Updated by mkravec over 3 years ago

  • Status changed from In Progress to Resolved

#15 Updated by okurz over 3 years ago

  • Copied to action #13974: btrfs_qgroups tests unstable (on o3) added

Also available in: Atom PDF