Project

General

Profile

Actions

action #11446

closed

Feature 318144: Btrfs quota group improvements

Added by maritawerner almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
-
Start date:
2016-04-01
Due date:
% Done:

100%

Estimated time:
Difficulty:

Description

For details see https://fate.suse.com/318144

First check if the Feature status is "done".

I propose that I improve the implementation of btrfs quota groups beyond what we had for SLES-12 GA. The benefits to this work would be that snapper and our end users would get improved accounting of space usage on btrfs. In addition I list a few items which are intended to generally improve the quality of btrfs quota groups.

Specifically:

Kernel Tasks:

  • Implement hierarchical quota groups. This way snapper could create parent groups which account properly for the groups below them. This may have a performance impact on quota rescan though.

  • Delete qgroup items on subvolume deletion (I wanted this for us earlier but it turned out to be more complicated than initially thought)

Btrfsprogs:

  • Accounting of heirarchical groups in btrfsck (right now btrfsck only cares about level 0 groups)

  • btrfsck to write out fixed qgroup items. This prevents user from having to do a rescan on unclean shutdown.


Related issues 1 (0 open1 closed)

Copied to openQA Tests - action #13974: btrfs_qgroups tests unstable (on o3)Rejectedmkravec2016-04-01

Actions
Actions #1

Updated by RBrownSUSE almost 8 years ago

  • Target version set to 168
Actions #2

Updated by okurz almost 8 years ago

  • Target version changed from 168 to Milestone 3
Actions #3

Updated by RBrownSUSE over 7 years ago

  • Priority changed from Normal to Urgent
Actions #4

Updated by mkravec over 7 years ago

  • Status changed from New to In Progress
  • Assignee set to mkravec
Actions #6

Updated by maritawerner over 7 years ago

Hi,I am out of office untill August, 14, my back-up is Sebastian Chlad schlad@suse.comBest regards,Marita Werner

Actions #7

Updated by mkravec over 7 years ago

Actions #8

Updated by okurz over 7 years ago

works fine in production on sles+extratests on x86_64: https://openqa.suse.de/tests/502327#step/btrfs_qgroups/25
fails on ppc64le: https://openqa.suse.de/tests/502327#step/btrfs_qgroups/25

Please check

Actions #9

Updated by mkravec over 7 years ago

This fail seems quite strange, test does this:

  1. btrfs qgroup limit 50m a
  2. for c in {1..40}; do dd if=/dev/zero bs=1M count=1 of=a/file\$c; done and fails to write at 34M on ppc64le.

I will check with btrfs people tomorrow, or maybe someone with ppc knowledge can explain.

Actions #10

Updated by RBrownSUSE over 7 years ago

please file a bug regarding the qgroups issue on ppc64le

Actions #11

Updated by mkravec over 7 years ago

  • Status changed from In Progress to Feedback

Block size is different on ppc and x86_64. Test needs to be updated to take this into account.

Test should also contain check for:
https://bugzilla.suse.com/show_bug.cgi?id=993841

Actions #12

Updated by mkravec over 7 years ago

  • Status changed from Feedback to In Progress
Actions #13

Updated by mkravec over 7 years ago

Actions #14

Updated by mkravec over 7 years ago

  • Status changed from In Progress to Resolved
Actions #15

Updated by okurz over 7 years ago

  • Copied to action #13974: btrfs_qgroups tests unstable (on o3) added
Actions

Also available in: Atom PDF