action #114415
closedcoordination #99303: [saga][epic] Future improvements for SUSE Maintenance QA workflows with fully automated testing, approval and release
coordination #97121: [epic] enable qem-bot comments on IBS (was: enable qa-maintenance/openQABot comments on smelt again)
[timeboxed:10h][spike solution] qem-bot comments on IBS size:S
0%
Description
Acceptance criteria¶
- AC1: As soon as testing for an individual release request is finished and if there is at least one failing openQA test a comment is written in IBS informing about the failing openQA tests
- AC2: If there is no failing openQA test related to an individual release request no comment is written
- AC3: Only a single comment is ever written on a release request (an existing comment can be updated)
Suggestions¶
Take a look how the openSUSE maintenance bot works in https://build.opensuse.org/request/show/989570#comment-1653437
Within qem-bot we already have the feature to send out comments but it seems so far it does not look at the state of openQA jobs so it writes a comment for all release requests whenever triggered which means informing even about all currently running jobs. Maybe the next best task is to actually look at the state and only inform about failing openQA tests
Think about moving the trigger point of sending a comment into the approval step of qem-bot or something so when no automatic approval is done instead a comment is written. This is where each individual release request should be looked at
Find out if OBS API supports editing comments, otherwise maybe delete old comments (https://build.opensuse.org/apidocs/)OBS API has a feature request for editing commentsEnsure that only a single comment is written, not multiple whenever qem-bot is called, so either update the existing or delete the old one if OBS does not support updating existing comments
Updated by livdywan about 2 years ago
- Subject changed from [timeboxed:10h][spike solution] qem-bot comments on IBS to [timeboxed:10h][spike solution] qem-bot comments on IBS size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by osukup about 2 years ago
it will cause same thing as before ... big bunch of emails to anybody related to Incident/ReleaseRequest.
btw. comment code in bot was +- taken from opensuse maintenance bot.
Updated by okurz about 2 years ago
osukup wrote:
it will cause same thing as before ... big bunch of emails to anybody related to Incident/ReleaseRequest.
Sure, anyone can opt to disable notifications and tweak in OBS now. But it should be significantly less emails when we only send emails if openQA jobs actually finished and failed (not just based on time schedule informing also about running jobs), right?
Updated by okurz almost 2 years ago
- Status changed from Workable to Blocked
- Assignee set to mkittler
Within #107923 we have implemented reading out openQA job comments to find openQA jobs that should not further block approval based on special comments. In the else branch of the according for loop in https://github.com/openSUSE/qem-bot/pull/82/files#diff-d44cab80bf43c62865043529f6e9883cc12ab37d49f5fb5af9e1bdc7c012dcaaR120 we now skip the approval early if there is one job found that is not ignored. At this time we could look into IBS or dashboard data if the request is older than a configurable time, e.g. older than 10 days, then provide a comment in IBS like "This request is blocked by at least one failing, not-ignored openQA test $url"
assigned to mkittler, blocked on the ticket #107923 you work on.
Updated by okurz almost 2 years ago
- Status changed from Blocked to Workable
- Assignee deleted (
mkittler)
Updated by tinita almost 2 years ago
- Status changed from Workable to In Progress
- Assignee set to tinita
Updated by tinita almost 2 years ago
- Related to action #98637: [timeboxed:20h] try to enable comments on IBS (and smelt) again from SUSE QA maintenance openQA test results size:M added
Updated by openqa_review almost 2 years ago
- Due date set to 2022-12-01
Setting due date based on mean cycle time of SUSE QE Tools
Updated by tinita almost 2 years ago
https://github.com/openSUSE/qem-bot/pull/85 - Log failed jobs
Updated by tinita almost 2 years ago
- Status changed from In Progress to Blocked
Updated by okurz almost 2 years ago
- Related to action #107923: qem-bot: Ignore not-ok openQA jobs for specific incident based on openQA job comment size:M added
Updated by tinita almost 2 years ago
- Status changed from Blocked to In Progress
Updated by mkittler almost 2 years ago
Because it was mentioned in the unblock meeting: I could do the auth on IBS when working on #111998. In particular in #111998#note-10 it worked to send a comment. My TODO list for making it work was comment #111998#note-5.
Updated by tinita almost 2 years ago
https://github.com/openSUSE/qem-bot/pull/92 - Proof of Concept: Post a comment
Updated by robert.richardson almost 2 years ago
- Copied to action #121228: qem-bot comments on IBS added
Updated by robert.richardson almost 2 years ago
- Status changed from In Progress to Resolved
follow up ticket: #121228