QA

That sounds like a good idea. I believe the bot can handle it without adding much complexity. There is also yet another bonus, without the calculation in "runtime" it should be easier and more transparent to clone a job with different subset if needed.

okurz wrote:

I agree with the problem statement. Not sure if moving more complexity into qem-bot is good though.

in reality for qem-bot increase of complexity is pretty minimal --> needs only modify this https://github.com/openSUSE/qem-bot/blob/master/openqabot/types/aggregate.py#L167-L168 loop ( +- 2-3 lines of code ?)

on other side it removes from os-autoinst-distri more than 20 lines of code and many more from OSD media definitions

jbaier_cz wrote:

That sounds like a good idea. I believe the bot can handle it without adding much complexity. There is also yet another bonus, without the calculation in "runtime" it should be easier and more transparent to clone a job with different subset if needed.

there still be some calculation online, but less complex

@okurz @cdywan we should increase priority / add it in workable ( as handling this vars is pretty big part of poo#109707 ) and we don't want duplicate complex code in os-autoinst-distri-openSUSE + openQA itself.

Sure, as soon as we have the current "normal" in the backlog resolved this would be one candidate

https://openqa.suse.de/tests/9296092#settings is a job using the new format with the _TEST_REPOS variables. Could you please check that the according code of https://github.com/os-autoinst/scripts/pull/177 still works with the new format? Maybe it's enough to simply extend https://github.com/os-autoinst/scripts/blob/master/openqa-trigger-bisect-jobs#L76 to look for _TEST_(ISSUES|REPOS) and maybe the sorting and grouping already works automatically even with repositories

Please look into #111710#note-13

okurz wrote:

Please look into #111710#note-13

bisect code needs some adjustment , on OSD are now TEST_ISSUES irrelevant + in reality code itself now don't work as excepted. Because it not undefine MAINT_TEST_REPO variable. If its defined (and in clone by default is defined ) whole *_TEST magic is skipped

https://github.com/os-autoinst/scripts/pull/182 -- add support for REPOS and fixed issue with MAINT_TEST_REPOS

unfortunately it has still faulty logic while triggering jobs...

This change broke our PublicCloud ARM64 test runs by changing the architecture of the _TEST_REPO to the architecture of the helper VM instead of using the *_TEST_TEMPLATE.
See e.g. https://openqa.suse.de/tests/9369145#settings where BASE_TEST_REPOS is x86_64, while it should be aarch64 (as previously defines in the BASE_TEST_TEMPLATE).

https://github.com/openSUSE/qem-bot/pull/65 introduces a temporary workaround while we search for a better solution. The issue is handled in #115652

Addendum: metadata change: https://gitlab.suse.de/qa-maintenance/metadata/-/merge_requests/681

ph03nix wrote:

This change broke our PublicCloud ARM64 test runs by changing the architecture of the _TEST_REPO to the architecture of the helper VM instead of using the *_TEST_TEMPLATE.
See e.g. https://openqa.suse.de/tests/9369145#settings where BASE_TEST_REPOS is x86_64, while it should be aarch64 (as previously defines in the BASE_TEST_TEMPLATE).

prety nonstandard use of _TEST_TEMPLATE..

https://github.com/openSUSE/qem-bot/pull/65 introduces a temporary workaround while we search for a better solution. The issue is handled in #115652

ook, workaround meged , have fun