Project

General

Profile

Actions

action #111605

closed

Moving isotovideo version patch from RPM spec to cmake made it not work in tests

Added by AdamWill over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2022-05-25
Due date:
% Done:

0%

Estimated time:

Description

okurz recently moved the sed command that patches isotovideo's version code to work when it's not part of a git repository from the RPM spec to the cmake bits:

https://github.com/os-autoinst/os-autoinst/pull/2067

however, this has the unfortunate consequence that isotovideo will not work in an RPM build %test block any more, because cmake only patches the installed copy of isotovideo, but when running the tests we use the unpatched isotovideo from the source tree.

SUSE's spec actually disables all the tests that run isotovideo, I think, but in Fedora I try to keep the list of disabled tests as small as possible and was running several tests that use isotovideo. Before this change those tests worked fine, after this change they don't.

I've put the sed command back into Fedora's spec (now in the %test section), but okurz asked me to still file an issue, so here it is.

Actions

Also available in: Atom PDF