https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842022-05-26T04:23:32ZopenSUSE Project Management ToolopenQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5231632022-05-26T04:23:32Zokurzokurz@suse.com
<ul><li><strong>Category</strong> set to <i>Regressions/Crashes</i></li><li><strong>Priority</strong> changed from <i>Low</i> to <i>Normal</i></li><li><strong>Target version</strong> set to <i>Ready</i></li></ul> openQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5243152022-05-31T09:35:45Zokurzokurz@suse.com
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li></ul> openQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5273992022-06-09T15:45:02Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li><li><strong>Assignee</strong> set to <i>mkittler</i></li></ul><p>I would have expected that amending the installed version is sufficient because tests can simply use isotovideo as-is. However, I now see that this can be problematic if git is not installed in the environment you're running tests in.</p>
<p>Maybe the following simple change does the trick for you? <a href="https://github.com/os-autoinst/os-autoinst/pull/2079" class="external">https://github.com/os-autoinst/os-autoinst/pull/2079</a> - Since tests shouldn't need the version anyways I suppose this should be good enough.</p>
openQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5274082022-06-09T15:48:26ZAdamWill
<ul></ul><p>mkittler wrote:</p>
<blockquote>
<p>I would have expected that amending the installed version is sufficient because tests can simply use isotovideo as-is. However, I now see that this can be problematic if git is not installed in the environment you're running tests in.</p>
<p>Maybe the following simple change does the trick for you? <a href="https://github.com/os-autoinst/os-autoinst/pull/2079" class="external">https://github.com/os-autoinst/os-autoinst/pull/2079</a> - Since tests shouldn't need the version anyways I suppose this should be good enough.</p>
</blockquote>
<p>The issue in our case isn't that git is not installed (it is), the issue is that the github source tarballs we run our package builds from are not git repositories.</p>
<p>I'll test that fix, thanks.</p>
openQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5277772022-06-10T13:10:28Zmkittlermarius.kittler@suse.com
<ul></ul><p>It should be fixed by the latest iteration of the PR which has already been merged.</p>
openQA Project - action #111605: Moving isotovideo version patch from RPM spec to cmake made it not work in testshttps://progress.opensuse.org/issues/111605?journal_id=5282062022-06-13T10:27:56Zmkittlermarius.kittler@suse.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>As mentioned in <a href="https://github.com/os-autoinst/os-autoinst/pull/2079#issuecomment-1152144170=" class="external">https://github.com/os-autoinst/os-autoinst/pull/2079#issuecomment-1152144170=</a> I tested all cases I can think of. So I'm resolving the issue. Feel free to reopen if something is missing.</p>