action #111506
closed
After seeing the code used to filter out development job groups I have a question:
Isn't possible to get a list of al job groups in the "development" parent group, instead of filtering for job group name keywords?
To my understanding, developers know that the parent group is meant for development and not that some keywords will do the trick, but I might be the only one not knowing it.
- Tags set to reactive work
- Priority changed from Normal to High
- Target version set to Ready
Well, it was started with just having job groups with "development" in the name and at that time parent groups didn't even exist yet.
But, yes, looking into the parent group as an alternative sounds like the way to go.
- Subject changed from qa-tools: qem-bot - Development results leaked to dashboard to qa-tools: qem-bot - Development results leaked to dashboard size:M
- Description updated (diff)
- Status changed from New to Workable
- Description updated (diff)
- Target version deleted (
Ready)
- Target version set to Ready
- Status changed from Workable to In Progress
- Assignee set to osukup
unfortunately openqa api call jobs/id returns only group and group_id but nothing about the parent group, so amount of API calls to openQA within bot is slightly higher now
okurz wrote:
Well, it was started with just having job groups with "development" in the name
The code seems to recognize groups with names containing Devel, Test and Timo as well as specifically Development.
- Status changed from In Progress to Feedback
cdywan wrote:
okurz wrote:
Well, it was started with just having job groups with "development" in the name
The code seems to recognize groups with names containing Devel, Test and Timo as well as specifically Development.
now it also checks the parent group ..., PR merged
mgrifalconi wrote:
Isn't possible to get a list of al job groups in the "development" parent group, instead of filtering for job group name keywords?
To my understanding, developers know that the parent group is meant for development and not that some keywords will do the trick, but I might be the only one not knowing it.
I provided another PR to drop the keyword-based filtering since that's how I read your comment but I guess it's not clear what the expected workflow is.
With Ondřej's change we have both, the parent group as well as the filtering based on keywords in the name of the job group.
- Status changed from Feedback to In Progress
found problem in filter code, "name" keys has different meaning ... so using magic number is only way
osukup wrote:
found problem in filter code, "name" keys has different meaning ... so using magic number is only way
Better make it a "configuration value". It's only a "magic number" if there is no proper explanation to what it means :) And, no, a comment in source code does not count :)
- Due date set to 2022-06-23
Setting due date based on mean cycle time of SUSE QE Tools
okurz wrote:
osukup wrote:
found problem in filter code, "name" keys has different meaning ... so using magic number is only way
Better make it a "configuration value". It's only a "magic number" if there is no proper explanation to what it means :) And, no, a comment in source code does not count :)
now is as one initialized variable in openqabot/__init__.py
- Status changed from In Progress to Feedback
- Status changed from Feedback to Resolved
should filter out develepment result correctly now
Also available in: Atom
PDF