Project

General

Profile

action #111506

Updated by okurz over 2 years ago

## Observation 
 Development group 'pstivanin-security@Server-DVD-Updates' results synced to qem dashboard 

 We already filter out development jobs in https://github.com/openSUSE/qem-bot/blob/master/openqabot/aggrsync.py#L53-L68 in case of aggregates or https://github.com/openSUSE/qem-bot/blob/master/openqabot/incsyncres.py#L48-L61 but today [pstivanin-security](https://openqa.suse.de/tests/overview?version=15-SP3&groupid=431&flavor=Server-DVD-Updates&distri=sle&build=20220523-1) *pstivanin-security* leaked to qem-dashboard in http://dashboard.qam.suse.de/incident/24199 when it shouldn't show it. 

 ## Acceptance criteria 
 * **AC1:** Development jobs should not be part of incident approval 
 * **AC2:** Dashboard no longer shows development jobs 

 ## Suggestions 
 * Don't let the bot submit development jobs to the dashboard 
 * Prevent duplication in https://github.com/openSUSE/qem-bot/blob/master/openqabot/aggrsync.py#L53-L68 and https://github.com/openSUSE/qem-bot/blob/master/openqabot/incsyncres.py#L48-L61 
 * Also exclude jobs that are part of any parent job group regardless of the job group names 

 ## Further notes 
 * A "development job" is a job in a job group or in a parent job group where the name contains "Development".

Back