action #10704

Make warnings in tests fatal

Added by okurz about 4 years ago. Updated 8 months ago.

Status:NewStart date:10/02/2016
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Feature requests
Target version:QA - future
Difficulty:
Duration:

Description

user story

As an openQA developer I want openQA unit and integration tests to fail when warnings are encountered to ensure not introduce regressions

acceptance criteria

  • "make test" fails if new warnings are encountered
  • the existing warnings are fixed or properly marked and skipped

tasks

  • It should help if we first fix all existing warnings to make new ones more visible
  • research how to make "prove" catch warnings and make them fatal
  • why does "prove -W" ("") not work as I expect it?
  • decide on an approach
  • make warnings fatal in all tests
  • fix existing warnings

further notes

History

#1 Updated by okurz about 4 years ago

see here for a potential starting point for discussion: https://github.com/os-autoinst/openQA/pull/539
How should we go on from there?

#2 Updated by okurz about 4 years ago

  • Description updated (diff)

#3 Updated by okurz about 4 years ago

  • Status changed from New to In Progress
  • Assignee set to okurz

PR ready gh#570

#4 Updated by okurz almost 4 years ago

  • Status changed from In Progress to Resolved

merged, done

#5 Updated by okurz almost 4 years ago

  • Status changed from Resolved to In Progress

no, wait, need to do the same for os-autoinst

#6 Updated by okurz almost 4 years ago

  • Assignee deleted (okurz)

on hold, anyone else can take over and fix that for os-autoinst. easy task as openQA is already done and can be used as reference :-)

#7 Updated by okurz about 3 years ago

  • Assignee set to rpalethorpe

as mentioned in https://github.com/os-autoinst/os-autoinst/pull/716#discussion_r100562659 rpalethorphe stepped up to look into some warnings.

#8 Updated by rpalethorpe about 3 years ago

  • Assignee deleted (rpalethorpe)

I just removed my custom code to catch warnings and added Test::Warnings to the virtio terminal tests. https://github.com/os-autoinst/os-autoinst/pull/722 Seems to work fine!

And now I am stepping down.

#9 Updated by coolo over 2 years ago

  • Status changed from In Progress to New
  • Target version set to future

#10 Updated by okurz over 1 year ago

  • Target version changed from future to future

#11 Updated by okurz 8 months ago

  • Category changed from 132 to Feature requests

Also available in: Atom PDF