QA (public) » openQA Project (public) » openQA Tests (public)

I am absolutely alright with whatever solution as long as it works reliably and doesn't produce false positives and negatives.

vpelcak wrote:

I am absolutely alright with whatever solution as long as it works reliably and doesn't produce false positives and negatives.

Empty repo can happen, for example by mistake of maint coordinator (as I saw recently). It's much less likely than the scenario of rejection and it can also be detected by maint team themselves, QEM when we see empty update, etc. I believe there's no need to check for every possible issue on every possible step of the process. Therefore I believe Oliver's proposal is absolutely fine.

okurz wrote:

This is actually something that can be solved just within os-autoinst-distri-opensuse, so changing project scope accordingly. Can you provide an example of a failing test which hit such a case? I am pretty sure that in whatever test module such tests fail the tests can be adapted. Do you think there is anything speaking against simply ignoring empty repositories? So instead of trying to install packages from a repository and fail simply don't treat it as an error, either by looking for installable packages and skipping if there are no packages or catch the error and skip.

I guess this needs a change in one of the following locations:

• https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/cae6400303ef59c58de143fbaf3050bf5e22457e/lib/qam.pm#L76
• https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/qam-updinstall/update_install.pm
• https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/tests/installation/add_update_test_repo.pm

I agree with @okurz .. it can be solved at test level adding common test if URL in MAINT_TEST_REPO/INCIDENT_REPO exist and then change vars on the fly or even better in main.pm on starting sequence of test

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.

This ticket was set to Normal priority but was not updated within the SLO period. Please consider picking up this ticket or just set the ticket to the next lower priority.