Project

General

Profile

action #103701

coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release

Resubmited incident (ID) with new release request (RR) inherits incident test results from previous RR

Added by dzedro 5 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
Start date:
2021-12-08
Due date:
% Done:

0%

Estimated time:

Description

When RR is declined it can be resubmitted with new RR.
Problem is that it's still same incident ID so it will have old results.
If the incident results passed then it can be auto-approved.
Regressions can pass trough.

e.g. S:M:21592:259811 http://dashboard.qam.suse.de/incident/21592

update.png (191 KB) update.png dzedro, 2021-12-08 11:53
rr.png (156 KB) rr.png dzedro, 2022-01-05 15:21
12291
12348

Related issues

Related to QA - action #108869: Missing (re-)schedules of SLE maintenance tests size:MResolved2022-03-24

Related to openQA Project - action #109310: qem-bot/dashboard - mixed old and new incidents size:MResolved2022-03-31

History

#1 Updated by dzedro 5 months ago

  • Category set to Concrete Bugs

#2 Updated by okurz 5 months ago

  • Project changed from openQA Project to QA
  • Category deleted (Concrete Bugs)
  • Target version set to future

When you say "Concrete Bugs", meaning a regression, can you reference a "last good"? Or is it actually a new feature request?

#3 Updated by dzedro 5 months ago

I'm not aware of any regression, but it's flaw in bot which can cause regressions.
It's confusing, people can think result is based on latest submission, but must be not.
Can be called feature request.

#4 Updated by dzedro 4 months ago

12348

Another example of old results being inherited from previous RR, there are just old test results or results don't exist anymore just the result statistics.
This is just annoying for reviewer and blocking auto-approve.
https://smelt.suse.de/incident/21598/

#5 Updated by osukup 4 months ago

yes, this is result of too simplified naming of INCIDENT by bot ( technical deept from past) ...

we need check where is used and change all places. (probadly MTUI + bot-ng + qem-dashboard

#6 Updated by osukup 4 months ago

another possibility is add variable ( for examle RRID) with RRID and then use this in approver part of bot, which unfortuanetly can work only for incidents part, not aggregates

#7 Updated by osukup 4 months ago

after code review .. it needs changes in bot-ng ( few lines) + in mtui (also should be simple)

#8 Updated by osukup 4 months ago

ahh , and I also forget about Template Generator (teregen)

#9 Updated by osukup 4 months ago

Ahh, I forgot .. there is problem...

We cant use RR ( review Request) because we start work on all incidents before are Review Requests created. ( Incidents in Staging Area)

vpelcak, dzedro .. any ideas ?

#10 Updated by dzedro 4 months ago

If we can't use RR then I don't know what options we have. Somehow drop previous results or filter results since day of new RR being submitted ?

#11 Updated by osukup 4 months ago

  • Status changed from New to In Progress
  • Assignee set to osukup

#12 Updated by osukup 4 months ago

  • Status changed from In Progress to Feedback

.. deployed, need check if it works as intended...

#13 Updated by osukup 4 months ago

  • Status changed from Feedback to Resolved

#14 Updated by okurz about 2 months ago

  • Related to action #108869: Missing (re-)schedules of SLE maintenance tests size:M added

#15 Updated by okurz about 1 month ago

  • Related to action #109310: qem-bot/dashboard - mixed old and new incidents size:M added

#16 Updated by okurz about 1 month ago

  • Parent task set to #91646

Also available in: Atom PDF