Project

General

Profile

Actions
Copy link

action #103398

closed

Send an AMQP message on comments taken over size:M

Added by coolo about 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
mkittler
Category:
Feature requests
Target version:
Ready
Start date:
2021-12-01
Due date:
% Done:

0%

Estimated time:

Description

Observation

job.done is sent out to AMQP, but it takes a polling to see if there were taken over comments. the done message neither carries the initial comments nor is a comment.created event sent. Please extend the messages, so we can have a unique view without polling.

Acceptance criteria

  • AC1: an amqp event is sent on internal comment creation
  • AC2: an amqp event is sent on comment take-over

Suggestions

Actions
Copy link
 #1

Updated by okurz about 3 years ago

  • Category set to Feature requests
  • Priority changed from Normal to Low
  • Target version set to Ready
Actions
Copy link
 #2

Updated by livdywan about 3 years ago

  • Subject changed from Send an AMQP message on comments taken over to Send an AMQP message on comments taken over size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #3

Updated by mkittler about 3 years ago

  • Assignee set to mkittler
Actions
Copy link
 #4

Updated by mkittler about 3 years ago

  • Status changed from Workable to In Progress
Actions
Copy link
 #5

Updated by okurz about 3 years ago

  • Status changed from In Progress to Feedback

PR looks fine, I already approved it and coolo gave thumbs up. mkittler does not plan to work on something related right now

Actions
Copy link
 #6

Updated by okurz almost 3 years ago

PR merged. My own openSUSE AMQP CLI is currently broken so I can't test it right now

Actions
Copy link
 #7

Updated by mkittler almost 3 years ago

Likely the unit tests are good enough. Whether the format of the messages is good enough @coolo could give feedback on.

Actions
Copy link
 #8

Updated by coolo almost 3 years ago

Took me a while to see one in action :)

 [x] 'suse.openqa.job.done':b'{"ARCH":"x86_64","BUILD":"79.1","FLAVOR":"Migration-from-SLE15-SPx","HDD_1":"SLES-15-SP1-x86_64-GM-gnome-updated.qcow2","ISO":"SLE-15-SP4-Online-x86_64-Build79.1-Media1.iso","MACHINE":"64bit","TEST":"offline_sles15sp1_ltss_media_basesys-srv_def_full","bugref":"bsc#1193212","bugurl":"https:\\/\\/bugzilla.suse.com\\/show_bug.cgi?id=1193212","group_id":null,"id":7960872,"newbuild":null,"reason":null,"remaining":25,"result":"failed"}'
 [x] 'suse.openqa.comment.create':b'{"bugref":"bsc#1193212","created":"2022-01-11T07:31:34Z","group_id":null,"id":467711,"job_id":7960872,"parent_group_id":null,"taken_over_from_job_id":7960871,"text":"bsc#1193212\\r\\n\\n\\n(Automatic takeover from t#7784098)\\n","updated":"2022-01-11T07:31:34Z","user":"zoecao"}'

The "user" almost made me discard this as a manual comment, but openqa webui also lies about who made this comment. So we should be fine.

Actions
Copy link
 #9

Updated by mkittler almost 3 years ago

  • Status changed from Feedback to Resolved

Nice, then I'm considering this done :-)

Actions
Copy link

Also available in: Atom PDF