QA

So far I can't reproduce it locally.

PR https://github.com/os-autoinst/openqa_review/pull/193 for better logging (traceback of the TypeError) merged

I found out this started on November 5th. I looked into October 29th until today.

With traceback:

RROR:openqa_review.openqa_review:Error retrieving details for bugref boo#1041112 (https://bugzilla.opensuse.org/show_bug.cgi?id=1041112): 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 694, in __init__
    self._init_bugzilla(bugzilla_browser)
  File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 734, in _init_bugzilla
    self.json = bugzilla_browser.json_rpc_get("/jsonrpc.cgi", "Bug.get", {"ids": [self.bugid]})["result"]["bugs"][0]
TypeError: 'NoneType' object is not subscriptable
.
ERROR:openqa_review.openqa_review:Error retrieving details for bugref bsc#1185342 (https://bugzilla.suse.com/show_bug.cgi?id=1185342): 'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 694, in __init__
    self._init_bugzilla(bugzilla_browser)
  File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 734, in _init_bugzilla
    self.json = bugzilla_browser.json_rpc_get("/jsonrpc.cgi", "Bug.get", {"ids": [self.bugid]})["result"]["bugs"][0]
TypeError: 'NoneType' object is not subscriptable

I already suspected this line. But when I retrieve the json locally, it looks ok.

https://gitlab.suse.de/openqa/openqa-review/-/jobs/687252

A little more debugging brought me to this JSON response:

{'\''error'\'': {'\''message'\'': '\''The username or password you entered is not valid.'\'', '\''code'\'': 300}, '\''id'\'': '\''https://bugzilla.suse.com/'\'', '\''result'\'': None}

It wasn't detected as a HTTP error because bugzilla sends a 200 OK in these cases :-/

So it seems the password was expired, and I changed it now, and set the new secret in the gitlab vars.

I will change the code, so that it checks for an error field in the JSON response.

Changing the password didn't help.

I wonder why I can login with that, but don't make a jsonrpc request.

It works with my personal user account.

% curl https://user:pass@apibugzilla.suse.com/jsonrpc.cgi?method=Bug.get&params=%5B%7B%22ids%22%3A+%5B1191745%5D%7D%5D"
{"error":{"message":"The username or password you entered is not valid.","code":300},"id":"https://bugzilla.suse.com/","result":null}

I set the password now to something completely different (instead of just changing the suffix which I thought was problematic due to gitlab expansion).
Now I can do a successful curl request (see last comment), but it still doesn't work from my gitlab (fork) pipeline.

Anyway, I changed the secret also in the original repo, and we will see tomorrow what happens. Meanwhile working on the code.

Draft: https://github.com/os-autoinst/openqa_review/pull/194

PR: https://github.com/os-autoinst/openqa_review/pull/195

tox -e cov, black and flake8 is successful for me locally.

Travis CI doesn't run on the PR because we used all credits this months already. Time to switch.

Looks like only the 'NoneType' object is not subscriptable part was fixed by https://github.com/os-autoinst/openqa_review/pull/195. So I've been creating a PR to fix the assertion (see #102440#note-5).

I attempted to fix the AssertionError as part of #101722 with https://github.com/os-autoinst/openqa_review/pull/192
But apparently I did not catch all cases.

Sorry I didn't mention this here.