Project

General

Profile

action #102350

Move openqa-review CI to Github Actions

Added by tinita 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2021-11-10
Due date:
2021-11-25
% Done:

0%

Estimated time:

Description

Observation

https://app.travis-ci.com/github/os-autoinst/openqa_review

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance or alter your Consume paid credits for OSS setting.

So credits are gone quite fast. We should move to GitHub Actions.

Acceptance criteria

  • AC1: All tests running on Travis so far are run on GHA instead
  • AC2: Publishing to pypi works

Suggestions

  • there's a Python Publish workflow template using pypa/gh-action-pypi-publish

Related issues

Related to QA - action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:MResolved2021-11-102021-11-25

Related to openQA Project - action #102590: openqa_review: pypi publishing based on every git commit in master, not just tags (was: Uploading to pypi stopped, also no git tags any more after 1.25.0)New2021-11-17

History

#1 Updated by tinita 3 months ago

  • Copied from action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added

#2 Updated by okurz 3 months ago

  • Priority changed from High to Normal

I don't see this as urgent though. We might just be ok with waiting as the project is not under rapid development. Honestly I would not even have added it to the backlog immediately. If you can't get it to work soon please move it out of the backlog again

#3 Updated by tinita 3 months ago

PR for testing (AC1): https://github.com/os-autoinst/openqa_review/pull/196

TODO: doctests (help wanted)

edit: Actually, doctests are also currently not executed on Travis CI. so AC1 is fulfilled I think.

#4 Updated by tinita 3 months ago

okurz wrote:

We might just be ok with waiting as the project is not under rapid development.

So we wait until december for open pull requests?

#5 Updated by tinita 3 months ago

  • Copied from deleted (action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M)

#6 Updated by tinita 3 months ago

  • Blocks action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added

#7 Updated by okurz 2 months ago

  • Blocks deleted (action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M)

#8 Updated by okurz 2 months ago

  • Related to action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added

#9 Updated by okurz 2 months ago

Apparently travis CI still works as we have seen for example in https://github.com/os-autoinst/openqa_review/pull/197

#10 Updated by okurz 2 months ago

Meh, I am stupid. travis CI checks are actually not triggered at all! :D

#11 Updated by tinita 2 months ago

  • Status changed from New to In Progress

https://github.com/os-autoinst/openqa_review/pull/196 was merged.
As discussed in the PR, it should be improved.

#12 Updated by tinita 2 months ago

  • Related to action #102590: openqa_review: pypi publishing based on every git commit in master, not just tags (was: Uploading to pypi stopped, also no git tags any more after 1.25.0) added

#13 Updated by tinita 2 months ago

  • Description updated (diff)

Publishing to pypi is handled in #102590

#14 Updated by tinita 2 months ago

  • Description updated (diff)

#15 Updated by tinita 2 months ago

  • Status changed from In Progress to Feedback

#16 Updated by tinita 2 months ago

  • Status changed from Feedback to In Progress

PR merged.

#17 Updated by tinita 2 months ago

I think I got doctest in combination with coverage working.

./.tox/cov/bin/py.test --cov=openqa_review --doctest-modules openqa_review/*
./.tox/cov/bin/py.test --cov=openqa_review  --cov-append

I added a dummy function with a doctest, and coverage was 100%
Will put it into the workflow tomorrow.

#19 Updated by tinita 2 months ago

  • Status changed from In Progress to Resolved

PR was merged.
We now have all tests running on GHA including doctests and coverage.

Also available in: Atom PDF