action #102440
closedopenqa-review pipeline failed with assert self.issue_type == "bugzilla"
Description
Observation¶
Several openqa-review pipeline steps are failing:
.
1680Traceback (most recent call last):
1681 File "/usr/bin/openqa-review", line 33, in <module>
1682 sys.exit(load_entry_point('openqa-review==0.0.0', 'console_scripts', 'openqa-review')())
1683 File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 1579, in main
1684 reminder_comment_on_issues(report)
1685 File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 1562, in reminder_comment_on_issues
1686 reminder_comment_on_issue(ie, min_days_unchanged)
1687 File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 1540, in reminder_comment_on_issue
1688 (last_comment_date, last_comment_text) = issue.last_comment
1689 File "/usr/lib/python3.8/site-packages/openqa_review/openqa_review.py", line 784, in last_comment
1690 assert self.issue_type == "bugzilla"
1691AssertionError
1692+ save_report=
1693+ cleanup
1694+ rm -r /tmp/tmp.OcUBfkY3gq
Suggestion¶
- Investigate what's causing the "assert" in production code
- Find out what's actually being returned (instead of a bugzilla issue)
Updated by livdywan over 2 years ago
- Copied from action #102437: Job age alert median followed by max size:S added
Updated by okurz over 2 years ago
- Related to action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added
Updated by okurz over 2 years ago
The error message about assert self.issue_type == "bugzilla" was already mentioned in #102200, isn't this a duplicate ticket?
Updated by mkittler over 2 years ago
- Status changed from New to In Progress
Regardless of that, here's a PR to fix the issue: https://github.com/os-autoinst/openqa_review/pull/197
Note that it doesn't look like https://github.com/os-autoinst/openqa_review/pull/195 would fix the issue.
Updated by okurz over 2 years ago
Yes, of course. I think https://github.com/os-autoinst/openqa_review/pull/195 was intended only to better handle the error but can't prevent it.
Updated by livdywan over 2 years ago
I seem to have thought #102200 was only about 'NoneType' object is not subscriptable. Obviously that doesn't fail any pipelines. I don't mind if this gets duped or amended retroactively - as you probably know I prefer distinct tickets, though, if you care which one I would choose.
Updated by openqa_review over 2 years ago
- Due date set to 2021-11-30
Setting due date based on mean cycle time of SUSE QE Tools
Updated by tinita over 2 years ago
okurz wrote:
Yes, of course. I think https://github.com/os-autoinst/openqa_review/pull/195 was intended only to better handle the error but can't prevent it.
No, it's about error handling for a different error.
Updated by mkittler over 2 years ago
- Status changed from In Progress to Resolved
The PR has been merged and the pipeline passes again.
Updated by mkittler over 2 years ago
- Status changed from Resolved to In Progress
Apparently coverage is missing and style checks don't pass. (Travis CI wasn't working at the time the PR was merged.)
Updated by mkittler over 2 years ago
- Status changed from In Progress to Feedback
The following PR fixes it: https://github.com/os-autoinst/openqa_review/pull/198
Updated by mkittler over 2 years ago
- Status changed from Feedback to Resolved
The PR has been merged with all checks successful again.