action #101210
closed
coordination #90086: [epic] Refactor container tests
Merge `podman_image.pm` and `docker_image.pm` into single module "image.pm"
Added by jlausuch over 3 years ago.
Updated 3 months ago.
Description
The only meaningful diff between these 2 files is:
podman_image.pm
:
install_podman_when_needed($host_distri);
docker_image.pm
:
install_docker_when_needed($host_distri);
...
scc_apply_docker_image_credentials() if (get_var('SCC_DOCKER_IMAGE'));
...
scc_restore_docker_image_credentials();
Since we have the variable CONTAINER_RUNTIME
, which can have docker
, podman
or docker,podman
, it doesn't make sense to keep duplicated code doing the same thing.
- Status changed from New to In Progress
- Assignee set to ybonatakis
- Status changed from In Progress to Blocked
- Related to action #101213: Merge `podman_3rd_party_images.pm` and `docker_3rd_party_images.pm` into single module "3rd_party_images.pm" added
- Related to action #101454: Merge `podman.pm` and `docker.pm` into single module "container_runtime.pm" added
- Assignee deleted (
ybonatakis)
- Status changed from Blocked to In Progress
- Assignee set to ybonatakis
- Status changed from In Progress to Blocked
- Assignee deleted (
ybonatakis)
i found another blocking issue. And we need to decide how to proceed. in additional there will be bigger changes than the one in the PR so in case that we want to break down the tasks i will mark it again as blocked for the time being
- Related to action #101451: Allow running both runtimes in the same job using main_containers schedule added
- Status changed from Blocked to In Progress
- Assignee set to ilausuch
- Status changed from In Progress to Resolved
Also available in: Atom
PDF