Project

General

Profile

Actions
Copy link

action #101210

closed

coordination #90086: [epic] Refactor container tests

Merge `podman_image.pm` and `docker_image.pm` into single module "image.pm"

Added by jlausuch over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
ilausuch
Target version:
-
Start date:
2021-10-20
Due date:
% Done:

0%

Estimated time:

Description

The only meaningful diff between these 2 files is:

podman_image.pm: 

install_podman_when_needed($host_distri);

docker_image.pm :

install_docker_when_needed($host_distri);
...
scc_apply_docker_image_credentials() if (get_var('SCC_DOCKER_IMAGE'));
...
scc_restore_docker_image_credentials();

Since we have the variable CONTAINER_RUNTIME, which can have docker, podman or docker,podman, it doesn't make sense to keep duplicated code doing the same thing.

Related issues 3 (0 open — 3 closed)

Related to Containers - action #101213: Merge `podman_3rd_party_images.pm` and `docker_3rd_party_images.pm` into single module "3rd_party_images.pm"Resolvedilausuch2021-10-20

Actions
Related to Containers - action #101454: Merge `podman.pm` and `docker.pm` into single module "container_runtime.pm"Resolvedilausuch2021-10-25

Actions
Related to Containers - action #101451: Allow running both runtimes in the same job using main_containers scheduleResolvedilausuch2021-10-25

Actions
Actions
Copy link

Also available in: Atom PDF