Project

General

Profile

Actions

action #101213

closed

coordination #90086: [epic] Refactor container tests

Merge `podman_3rd_party_images.pm` and `docker_3rd_party_images.pm` into single module "3rd_party_images.pm"

Added by jlausuch over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
-
Start date:
2021-10-20
Due date:
% Done:

0%

Estimated time:

Description

The only meaningful diff between these 2 files is:

podman_3rd_party_images.pm:

script_run("echo 'Container base image tests:' > /var/tmp/podman-3rd_party_images_log.txt");
...
install_podman_when_needed($host_distri);
...
upload_3rd_party_images_logs('podman');

docker_3rd_party_images.pm :

script_run("echo 'Container base image tests:' > /var/tmp/docker-3rd_party_images_log.txt");
...
install_docker_when_needed($host_distri);
...
upload_3rd_party_images_logs('docker');

Since we have the variable CONTAINER_RUNTIME, which can have docker, podman or docker,podman, it doesn't make sense to keep duplicated code doing the same thing.


Related issues 1 (0 open1 closed)

Related to Containers - action #101210: Merge `podman_image.pm` and `docker_image.pm` into single module "image.pm"Resolvedilausuch2021-10-20

Actions
Actions #1

Updated by jlausuch over 2 years ago

  • Status changed from New to Workable
Actions #2

Updated by jlausuch over 2 years ago

  • Priority changed from Normal to High
Actions #3

Updated by ybonatakis over 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ybonatakis
Actions #4

Updated by jlausuch over 2 years ago

  • Priority changed from High to Normal
Actions #5

Updated by jlausuch over 2 years ago

  • Status changed from In Progress to Blocked
Actions #7

Updated by jlausuch over 2 years ago

  • Related to action #101210: Merge `podman_image.pm` and `docker_image.pm` into single module "image.pm" added
Actions #8

Updated by ybonatakis over 2 years ago

  • Assignee deleted (ybonatakis)
Actions #9

Updated by jlausuch over 2 years ago

  • Status changed from Blocked to Workable
Actions #10

Updated by ilausuch over 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ilausuch
Actions #12

Updated by ilausuch over 2 years ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF