action #101210
closedcoordination #90086: [epic] Refactor container tests
Merge `podman_image.pm` and `docker_image.pm` into single module "image.pm"
0%
Description
The only meaningful diff between these 2 files is:
podman_image.pm:
install_podman_when_needed($host_distri);
docker_image.pm :
install_docker_when_needed($host_distri);
...
scc_apply_docker_image_credentials() if (get_var('SCC_DOCKER_IMAGE'));
...
scc_restore_docker_image_credentials();
Since we have the variable CONTAINER_RUNTIME, which can have docker, podman or docker,podman, it doesn't make sense to keep duplicated code doing the same thing.
Updated by ybonatakis over 2 years ago
- Status changed from New to In Progress
- Assignee set to ybonatakis
i assigned to myself as i have already done some work in this direction. https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13370
just help me clarify the name. I renamed podman_image and docker_image to container_images. the ticket suggests image.pm. i still looking for a better one.
Updated by jlausuch over 2 years ago
Blocked by: https://progress.opensuse.org/issues/101442
Updated by jlausuch over 2 years ago
- Related to action #101213: Merge `podman_3rd_party_images.pm` and `docker_3rd_party_images.pm` into single module "3rd_party_images.pm" added
Updated by jlausuch over 2 years ago
- Related to action #101454: Merge `podman.pm` and `docker.pm` into single module "container_runtime.pm" added
Updated by ybonatakis over 2 years ago
Updated by ybonatakis over 2 years ago
- Status changed from Blocked to In Progress
- Assignee set to ybonatakis
https://progress.opensuse.org/issues/101442 is resolved. taking as i have already some code ready for it
Updated by ybonatakis over 2 years ago
Updated by ybonatakis over 2 years ago
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13891 is implemented as part of this and is merged.
Now there is no dependency on YAML_SCHEDULE and all container jobs are going through main_container. This will help to no break anything when we merge the two modules from this ticket
Updated by ybonatakis over 2 years ago
- Status changed from In Progress to Blocked
- Assignee deleted (
ybonatakis)
i found another blocking issue. And we need to decide how to proceed. in additional there will be bigger changes than the one in the PR so in case that we want to break down the tasks i will mark it again as blocked for the time being
Updated by ilausuch over 2 years ago
- Related to action #101451: Allow running both runtimes in the same job using main_containers schedule added
Updated by ilausuch over 2 years ago
- Status changed from Blocked to In Progress
- Assignee set to ilausuch
Updated by ilausuch over 2 years ago
Updated by ilausuch over 2 years ago
- Status changed from In Progress to Resolved