action #97952
closedHandle "unable to upgrade ws to command server" better size:S
Description
Motivation¶
Multiple people report problems seeing the error message "unable to upgrade ws to command server", especially on new openQA installations.
Acceptance criteria¶
- AC1: openQA prevents the error condition related to the message "unable to upgrade ws to command server" automatically or provides a better hint in the message what to do or documentation mentions the string and explains what to do
Suggestions¶
- Call
git grepfor the string, try to understand the surrounding code, try to come up with a code improvement (in some minutes). If you can't improve the code, at least improve the string. If that is not feasible, go for documentation, whatever is lowest effort
Further details¶
The problem was brought up in https://suse.slack.com/archives/C02CANHLANP/p1630571139069400 but also at an earlier time.
Updated by mkittler over 2 years ago
- Status changed from New to In Progress
- Assignee set to mkittler
After chatting it turned out to be a misconfigured WORKER_HOSTNAME. I created a PR to make it harder to misconfigure it: https://github.com/os-autoinst/openQA/pull/4161
Updated by okurz over 2 years ago
- Status changed from In Progress to New
Great. Setting back to "New" to show up for estimation. I imagine we can still improve the handling of the error condition as described in the ticket description.
Updated by okurz over 2 years ago
- Subject changed from Handle "unable to upgrade ws to command server" better to Handle "unable to upgrade ws to command server" better size:S
- Description updated (diff)
- Status changed from New to Workable
Updated by okurz over 2 years ago
@mkittler https://github.com/os-autoinst/openQA/pull/4161 merged, so that is good. Now, what are your plans regarding the further suggestions/ACs in this ticket, continue or unassign and leave to someone else?
Updated by mkittler over 2 years ago
I guess it'll be useful to direct people to the debugging steps in our documentation when the error occurs, e.g. using the usual help icon. Otherwise the error message itself is correct; it is indeed unable to upgrade the HTTP connection to use web sockets.
The problem wasn't caused by a bug in openQA itself, so there's nothing to fix.
Updated by mkittler over 2 years ago
- Status changed from Workable to In Progress
Updated by okurz over 2 years ago
I approved the PR. Do you think it would still be helpful to point to the documentation section in the error string itself? If yes, this could be a great beginner task for Moritz. As the alternative we could mention "unable to upgrade ws to command server" in documentation directly.
Updated by VANASTASIADIS over 2 years ago
- Due date set to 2021-09-18
Setting due date based on mean cycle time of SUSE QE Tools
Updated by mkittler over 2 years ago
Not sure what you mean, https://github.com/os-autoinst/openQA/pull/4164 already provides a link from the UI which shows the error to the documentation.
Updated by mkittler over 2 years ago
- Status changed from In Progress to Feedback
Updated by okurz over 2 years ago
As discussed in daily 2021-09-10 the last part could be done by kodymo as "beginner task", e.g. adding the explicit string "unable to upgrade ws to command server" in the documentation.
Updated by mkittler over 2 years ago
- Assignee changed from mkittler to kodymo
The web UI already has a link to the documentation shown next to the error message. However, we would like to add "unable to upgrade ws to command server" to https://open.qa/docs/#debugdevelmode (relevant repository is https://progress.opensuse.org/issues/97952) additionally so one can search for the message within the documentation. I'll leave this task to @kodymo so he has a simple change for creating his first PR in the openQA repository.
Updated by kodymo over 2 years ago
- Status changed from Feedback to Resolved
Added the message "unable to upgrade ws to command server" to the documentation, as requested
PR (merged): https://github.com/os-autoinst/openQA/pull/4187