Project

General

Profile

action #96813

coordination #93668: [epic] Redesign Installation test modules

Leave only one getter for GuidedSetupController in Distribution::Opensuse::Tumbleweed

Added by oorlov 4 months ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
2021-08-12
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Currently, two getters for GuidedSetupController are specified in Distribution::Opensuse::Tumbleweed: get_partitioner and get_guided_partitioner. We should refactor this to have only one getter. That will make our structure consistent and allow to use DistributionProvider to control which GuidedSetupController to use for the certain version of product.

Task

  1. Leave only one getter for GuidedSetupController in Distribution::Opensuse::Tumbleweed (The one which is pointing to Installation::Partitioner::LibstorageNG::v4_3::GuidedSetupController);
  2. Make sure that there are no failures in test runs (e.g. in YaST job Group, openSUSE Tumbleweed, Leap 15, Maintenance tests (https://openqa.suse.de/group_overview/321));
  3. Implement methods in Installation::Partitioner::LibstorageNG::v4_3::GuidedSetupController that will be required to pass encrypt_lvm, encrypt_no_lvm, encrypt_lvm_ignore_existing, encrypt_lvm_reuse_existing and others, that still use old Installation::Partitioner::LibstorageNG::GuidedSetupController

Suggestions

  • Consider migrating one at a time from one controller to the other and ask for review for after each case. Ticket might need to be split.
  • The other option is to do a pure refactor and move all the methods without further modifications.

History

#1 Updated by oorlov 4 months ago

  • Description updated (diff)

#2 Updated by JERiveraMoya 3 months ago

  • Description updated (diff)

#3 Updated by JERiveraMoya 3 months ago

  • Tags deleted (qe-yast-refinement)
  • Description updated (diff)
  • Status changed from New to Workable

#4 Updated by oorlov 2 months ago

  • Status changed from Workable to In Progress

#5 Updated by oorlov 2 months ago

  • Assignee set to oorlov

#6 Updated by oorlov about 2 months ago

PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13418

This PR includes refactoring of the pages, controllers and test modules for Guided Setup.

Schedules changed only for cryptlvm and crypt_no_lvm scenarios to reduce scope for review and eliminate potential mistakes. Other schedules will be covered in further PRs.

#7 Updated by oorlov 19 days ago

  • Status changed from In Progress to Resolved

PR for guided_setup and encrypt_lvm_ignore_existing: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13646

PR for lvm and lvm_no_separate_home: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13512

The initial task is not reached: the getter for GuidedSetupController on 15-SP2 is kept, but for SP3, SP4 we refactored the guided setup test modules to make them more transparent and atomic. As Sp2 still use needles approach and LibyuiClient cannot be applied there, we'll keep the existing getter for now. In case it will be required in future, we'll rewrite it in the follow-up tickets.

#8 Updated by oorlov 18 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF