action #96813
Updated by JERiveraMoya over 2 years ago
## Motivation
Currently, two getters for GuidedSetupController are specified in Distribution::Opensuse::Tumbleweed: `get_partitioner` and `get_guided_partitioner`. We should refactor this to have only one getter. That will make our structure consistent and allow to use DistributionProvider to control which GuidedSetupController to use for the certain version of product.
## Task
1. Leave only one getter for GuidedSetupController in Distribution::Opensuse::Tumbleweed (The one which is pointing to `Installation::Partitioner::LibstorageNG::v4_3::GuidedSetupController`);
2. Make sure that there are no failures in test runs (e.g. in YaST job Group, openSUSE Tumbleweed, Leap 15, Maintenance tests (https://openqa.suse.de/group_overview/321));
3. Implement methods in `Installation::Partitioner::LibstorageNG::v4_3::GuidedSetupController` that will be required to pass `encrypt_lvm`, `encrypt_no_lvm`, `encrypt_lvm_ignore_existing`, `encrypt_lvm_reuse_existing` and others, that still use old Installation::Partitioner::LibstorageNG::GuidedSetupController
## Suggestions
- Consider migrating one at a time from one controller to the other and ask for review for after each case.
Ticket might need to be split.
- The other option is to do a pure refactor and move all the methods without further modifications.