action #96801: Refactor existing select_role test module to be explicit and not use test_data - qe-yam - openSUSE Project Management Tool

Actions

Copy link

action #96801

closed

coordination #93668: [epic] Redesign Installation test modules

Refactor existing select_role test module to be explicit and not use test_data

Added by oorlov over 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

JRivrain

Target version:

Current

Start date:

2021-08-12

Due date:

% Done:

Estimated time:

Description

We have nicely implemented select_role test module which already uses OOP and Libyui. But since we've discovered that it will be more transparent to have test module to be explicit in what it does, we need to refactor the existing select_role test module a bit.

Scope:¶

Job Groups: YaST, openSUSE Tumbleweed, openSUSE Leap 15

Task:¶

Find all the places where select_role is used to identify which roles it selects;
Create as many test modules as this test module selects and name them respectively (e.g. select_role_textmode, select_role_transactional_server`);
Replace all the occurrences of select_role with the new test modules.

If possible (not to long name, call it select(install)_system_role_X.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by oorlov over 3 years ago

Related to action #96803: Replace system_role test module with the ones that explicit in what role is selected added

Actions

Copy link

Updated by oorlov over 3 years ago

Parent task changed from #93276 to #93668

Actions

Copy link

Updated by oorlov over 3 years ago

Subject changed from Refactor existing select_role test module to be concrete and not use test_data to Refactor existing select_role test module to be explicit and not use test_data

Actions

Copy link

Updated by JERiveraMoya about 3 years ago

Tags deleted (~~qe-yast-refinement~~)
Description updated (diff)
Status changed from New to Workable

Actions

Copy link

Updated by JRivrain about 3 years ago

Status changed from Workable to In Progress
Assignee set to JRivrain

Actions

Copy link

Updated by JRivrain about 3 years ago

list of affected yamls:

`
jonathan@waaa-amazing:/var/lib/openqa/share/tests/sle/schedule (select_role)$ for i in $(grep -r select_role |cut -d: -f1); do echo $i; grep "system_role:" $i -a2 ; echo \ ; done |egrep -v "- |software"

yast/lvm/lvm_thin_provisioning.yaml
test_data:
system_role:
default: 'SLES with GNOME'

yast/transactional_server/create_hdd_transactional_server.yaml
test_data:
system_role:
default: 'Transactional Server'

yast/textmode/textmode.yaml
test_data:
system_role:
default: 'Text Mode'

yast/textmode/textmode@svirt-xen.yaml
test_data:
system_role:
default: 'Text Mode'

yast/installer_extended/installer_extended.yaml
text: 版軟體的
system_role:
default: 'Text Mode'

yast/minimalx_zvm.yaml
test_data:
system_role:
selection: 'Generic Desktop'

yast/addon-module-ftp.yaml
test_data:
system_role:
default: 'HA node'
selection: 'Text Mode'

yast/opensuse/lvm/lvm_thin_provisioning.yaml
test_data:
<<: !include test_data/yast/lvm_thin_provisioning/lvm_thin_provisioning.yaml
system_role:
default: null
selection: 'Desktop with GNOME'

yast/opensuse/lvm_raid1/lvm+raid1.yaml
test_data:
system_role:
default: null
selection: 'Desktop with KDE Plasma'

yast/opensuse/transactional_server/create_hdd_transactional_server.yaml
test_data:
system_role:
default: null
selection: 'Transactional Server'

yast/opensuse/transactional_server/transactional_server.yaml
test_data:
system_role:
default: null
selection: 'Transactional Server'

qam/QR/15-SP3/lvm/lvm_thin_provisioning.yaml
test_data:
system_role:
default: 'SLES with GNOME'

qam/QR/15-SP3/textmode/textmode.yaml
test_data:
system_role:
default: 'Text Mode'`

Actions

Copy link