Actions
action #96564
closedcoordination #93883: [epic] Speedup openQA coverage tests with running minion jobs synchronously using new upstream "perform_jobs_in_foreground" mojo function
Speed up `t/ui/12-needle-edit.t` and `t/ui/21-admin-needles.t` by avoiding forking to run Minion jobs size:M
Description
These tests start GRU as sub process explicitly via with_gru parameter when doing the UI test setup. We should check whether this means we collect coverage for running Minion jobs in forks (for #93883).
acceptance criteria¶
- AC1: Tests are measurably faster
- AC2: No coverage drop despite implementing
further notes¶
- We've recently done something similar for other tests: https://github.com/os-autoinst/openQA/pull/4095
- A comment within the code should state whether the
with_gruparameter means that we collect coverage for running Minion jobs in forks. - We do not collect the coverage data for Minion jobs ran via
with_gruor avoid running these Minion jobs in forks.
Updated by okurz over 3 years ago
- Tracker changed from coordination to action
- Category set to Feature requests
- Priority changed from Normal to Low
- Target version set to Ready
Updated by livdywan over 3 years ago
- Subject changed from Speed up `t/ui/12-needle-edit.t` and `t/ui/21-admin-needles.t` by avoiding forking to run Minion jobs to Speed up `t/ui/12-needle-edit.t` and `t/ui/21-admin-needles.t` by avoiding forking to run Minion jobs size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by kraih over 3 years ago
Updated by kraih over 3 years ago
- Status changed from In Progress to Resolved
And second PR. https://github.com/os-autoinst/openQA/pull/4173
Actions