QA » openQA Project » openQA Infrastructure

this is missing samba on worker in WSL (Windows) test, which was problem on imgtester. Now is probably irrelevant

I'm unsure what the best approach is, so I'm documenting what I was pondering on:

The logs reveal the use of Samba in two places, the arguments passed to qemu as well as the error which looks like a "debug" message:

[2021-07-29T11:35:34.940 UTC] [debug] starting: /usr/bin/qemu-system-x86_64 -vga qxl -only-migratable -chardev ringbuf,id=serial0,logfile=serial0,logappend=on -serial chardev:serial0 -audiodev none,id=snd0 -device intel-hda -device hda-output,audiodev=snd0 -global isa-fdc.fdtypeA=none -m 2048 -machine q35 -cpu host -netdev user,id=qanet0,smb=/var/lib/openqa/pool/2 -device virtio-net,netdev=qanet0,mac=52:54:00:12:34:56 -device usb-ehci -device usb-tablet -smp 1 -enable-kvm -no-shutdown -vnc :92,share=force-shared -device virtio-serial -chardev 
[...]
[2021-07-29T11:35:35.132 UTC] [debug] QEMU: QEMU emulator version 4.2.1 (openSUSE Leap 15.2)
[2021-07-29T11:35:35.132 UTC] [debug] QEMU: Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers
[2021-07-29T11:35:35.132 UTC] [debug] QEMU: qemu-system-x86_64: Could not find '/usr/sbin/smbd', please install it

• The arguments are added in qemu.pm iff QEMU_ENABLE_SMBD is defined. We could presumably check wether Samba's available here before we even do that.
• We could die "QEMU: $line" if $line =~ m/Could not find.+please install it/; in process_qemu_output.
  • One step further, we could error on anything that's not related to version or copyright.
  • A test based on what's already in 18-qemu-options.t could assert that "please install" or other messages result in a clean failure.
• Should we make Samba a dep and use it in tests? I can't think of an easy way to mock it.

cdywan wrote:

• Should we make Samba a dep and use it in tests? I can't think of an easy way to mock it.

is should be dependency of os-autoinst-distri-opensuse

please keep https://progress.opensuse.org/issues/96272#Acceptance-criteria in mind, the primary object is to make the error message appear in the job reason, not necessarily fix the problem :)

It seems be bigger problem than I excepted.

Code for this is in os-autoinst/OpenQA/Qemu/Proc.pm:

sub exec_qemu {
    my ($self) = @_;

    my @params = $self->gen_cmdline();
    session->enable;
    bmwqemu::diag('starting: ' . join(' ', @params));
    session->enable_subreaper;

    my $process = $self->_process;
    $self->{_qemu_terminated} = 0;
    $process->on(
        collected => sub {
            $self->{_qemu_terminated} = 1;
            unless ($self->{_stopping}) {
                my $msg = 'QEMU exited unexpectedly, see log for details';
                $msg = 'QEMU was killed due to the system being out of memory' if ($self->check_qemu_oom == 0);
                bmwqemu::serialize_state(component => 'backend', msg => $msg);
            }   
        }); 
    $process->code(sub {
            $SIG{__DIE__} = undef;    # overwrite the default - just exit
            system $self->qemu_bin, '-version';
            # don't try to talk to the host's PA
            $ENV{QEMU_AUDIO_DRV} = "none";
            exec(@params);
    });     

we can get stdout from $proc but this will break our logging to autoinst-log.txt which is unacceptable --> see http://quasar.suse.cz/tests/7268#details

$process->read_all_stdout flush stdoud .. so channel for our logger will be empty..

osukup wrote:

we can get stdout from $proc but this will break our logging to autoinst-log.txt which is unacceptable --> see http://quasar.suse.cz/tests/7268#details

$process->read_all_stdout flush stdoud .. so channel for our logger will be empty..

What I see here is this:

[2021-10-06T14:44:21.320 CEST] [debug] DIAGGG:'QEMU emulator version 5.2.0 (SUSE Linux Enterprise 15)
  '
  'Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers
  '
  'qemu-system-x86_64: Could not find \'/usr/sbin/smbd\', please install it
  '

dmesg: read kernel buffer failed: Operation not permitted

So I can see the error we want to catch. The whitespace just looks garbled. Maybe you can just strip it?

I'd say push what you have and it should make it easier to spot the problem

cdywan wrote:

osukup wrote:

we can get stdout from $proc but this will break our logging to autoinst-log.txt which is unacceptable --> see http://quasar.suse.cz/tests/7268#details

$process->read_all_stdout flush stdoud .. so channel for our logger will be empty..

What I see here is this:

[2021-10-06T14:44:21.320 CEST] [debug] DIAGGG:'QEMU emulator version 5.2.0 (SUSE Linux Enterprise 15)
  '
  'Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers
  '
  'qemu-system-x86_64: Could not find \'/usr/sbin/smbd\', please install it
  '

dmesg: read kernel buffer failed: Operation not permitted

So I can see the error we want to catch. The whitespace just looks garbled. Maybe you can just strip it?

I'd say push what you have and it should make it easier to spot the problem

Look at autoinst-log.txt ... exactly this info is missing from log (DIAGG: .... is Data::Dumper in Callback) , which is exactly why we can't use this way

So originally I hoped we could improve the "log gathering" within os-autoinst but I would be ok to parse the logs in openQA and update the reason retroactively. We already do something similar in https://github.com/os-autoinst/openQA/blob/7ea206aff0f8cf33abb039bb12ab0da25e90fcbc/lib/OpenQA/Worker/Job.pm#L567 for special cases