Project

General

Profile

Actions

action #121357

closed

coordination #109668: [saga][epic] Stable and updated non-qemu backends for SLE validation

coordination #109740: [epic] Stable os-autoinst unit tests with good coverage

[easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:M

Added by okurz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

All code should be fully covered or marked as uncoverable so that we can spot gaps easily. As of this writing we have 98.86%.

Acceptance criteria

  • AC1: All places that could be covered by tests but aren't have been identified
  • AC2: Codecov reports 100%

Comments


Related issues 2 (0 open2 closed)

Copied from openQA Project - action #94952: [easy][beginner] Increase code coverage of os-autoinst basetest.pm size:MResolvedrobert.richardson2021-06-30

Actions
Copied to openQA Project - action #122047: [tools] tesseract ocr test failsResolvedosukup2022-12-15

Actions
Actions #1

Updated by okurz about 1 year ago

  • Copied from action #94952: [easy][beginner] Increase code coverage of os-autoinst basetest.pm size:M added
Actions #2

Updated by livdywan about 1 year ago

  • Subject changed from [easy][beginner] Ensure 100% test coverage of t/ to [easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by livdywan about 1 year ago

Discussed with Ondřej, first small PR: https://github.com/os-autoinst/os-autoinst/pull/2229

Actions #4

Updated by livdywan about 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to osukup
Actions #7

Updated by osukup about 1 year ago

after merging @chris PR's -> 99.04%

it should be more ->

codecov reports:

Commit YAML is invalid
Coverage data is unable to be displayed, as the commit YAML appears to be invalid.

so it contains old data :(

Actions #8

Updated by osukup about 1 year ago

https://github.com/os-autoinst/os-autoinst/pull/2233 --> add terrasect-ocr to os-autoinst test dependencies

Actions #9

Updated by osukup about 1 year ago

so new PR uncovered https://github.com/os-autoinst/os-autoinst/actions/runs/3703495822/jobs/6275014804

7: "tesseract" unexpectedly returned exit value 1 at /opt/ppmclibs/blib/lib/tinycv.pm line 113.
631
7:  at /opt/ocr.pm line 20
632
7: # Tests were run but no plan was declared and done_testing() was not seen.
633
7: # Looks like your test exited with 1 just after 2.
634
7: [11:10:03] ./t/02-test_ocr.t .......................... 
635
7: Dubious, test returned 1 (wstat 256, 0x100)
Actions #10

Updated by osukup about 1 year ago

Actions #11

Updated by osukup about 1 year ago

--> 02-test_ocr.t 94% , needs only mark skip codepath with uncoverable statement

Actions #14

Updated by osukup about 1 year ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF