action #121357
closedcoordination #109668: [saga][epic] Stable and updated non-qemu backends for SLE validation
coordination #109740: [epic] Stable os-autoinst unit tests with good coverage
[easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:M
Description
Motivation¶
All code should be fully covered or marked as uncoverable so that we can spot gaps easily. As of this writing we have 98.86%.
Acceptance criteria¶
- AC1: All places that could be covered by tests but aren't have been identified
- AC2: Codecov reports 100%
Comments¶
- Current coverage: https://app.codecov.io/gh/os-autoinst/os-autoinst/tree/master/
- Use ignore statements for lines that cannot be covered by actual tests
Updated by okurz almost 2 years ago
- Copied from action #94952: [easy][beginner] Increase code coverage of os-autoinst basetest.pm size:M added
Updated by livdywan almost 2 years ago
- Subject changed from [easy][beginner] Ensure 100% test coverage of t/ to [easy][beginner] Ensure 100% test coverage of t/ in os-autoinst size:M
- Description updated (diff)
- Status changed from New to Workable
Updated by livdywan almost 2 years ago
Discussed with Ondřej, first small PR: https://github.com/os-autoinst/os-autoinst/pull/2229
Updated by livdywan almost 2 years ago
- Status changed from Workable to In Progress
- Assignee set to osukup
Updated by livdywan almost 2 years ago
Updated by livdywan almost 2 years ago
Updated by osukup almost 2 years ago
after merging @chris PR's -> 99.04%
it should be more ->
codecov reports:
Commit YAML is invalid
Coverage data is unable to be displayed, as the commit YAML appears to be invalid.
so it contains old data :(
Updated by osukup almost 2 years ago
https://github.com/os-autoinst/os-autoinst/pull/2233 --> add terrasect-ocr to os-autoinst test dependencies
Updated by osukup almost 2 years ago
so new PR uncovered https://github.com/os-autoinst/os-autoinst/actions/runs/3703495822/jobs/6275014804
7: "tesseract" unexpectedly returned exit value 1 at /opt/ppmclibs/blib/lib/tinycv.pm line 113.
631
7: at /opt/ocr.pm line 20
632
7: # Tests were run but no plan was declared and done_testing() was not seen.
633
7: # Looks like your test exited with 1 just after 2.
634
7: [11:10:03] ./t/02-test_ocr.t ..........................
635
7: Dubious, test returned 1 (wstat 256, 0x100)
Updated by osukup almost 2 years ago
- Copied to action #122047: [tools] tesseract ocr test fails added
Updated by osukup almost 2 years ago
--> 02-test_ocr.t 94% , needs only mark skip codepath with uncoverable statement
Updated by okurz almost 2 years ago
It should be clear where to continue. Currently https://app.codecov.io/gh/os-autoinst/os-autoinst/tree/master/t mentions the following test files as not completely covered:
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/10-terminal.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/18-qemu.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/19-isotovideo-command-processing.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/22-svirt.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/27-consoles-vmware.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/28-signalblocker.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/31-sshSerial.t
- https://app.codecov.io/gh/os-autoinst/os-autoinst/blob/master/t/32-console_proxy.t
Updated by osukup almost 2 years ago
https://github.com/os-autoinst/os-autoinst/pull/2241 should be last pr
Updated by osukup almost 2 years ago
- Status changed from In Progress to Resolved