action #94880
closedCarry-over despite mismatch of failing job modules
Description
observation¶
The comment https://openqa.opensuse.org/tests/1811337#comments has been taken from https://openqa.opensuse.org/tests/1805129 although the job fails in one additional test module.
further information¶
The current and previous jobs contain both a bug reference within the title of a step of a failed/softfailed module:
rogue workqueue lockup bsc#1126782 - Serial error: [ 5297.323977] BUG: workqueue lockup - pool cpus=0 node=0 flags=0x0 nice=0 stuck for 34s!
(https://openqa.opensuse.org/tests/1805129#step/vhostmd/37)
The code in _failure_reason
looks like it would only consider that bug reference then, ignoring the list of actually failed modules. The problematic code has been introduced by https://github.com/os-autoinst/openQA/commit/ef5f07c561cb4bb6139d17b98b616af6b81a8fff so we should take care to still support that use-case.
impact¶
The release tooling relies on that, if it just ignores failures it can result in broken releases.
Updated by mkittler over 3 years ago
- Assignee set to mkittler
I suppose the solution is to only "shrink down" test modules containing the bugref to the bugref but not any other test modules. This way the failures in different modules referencing the same bug would still be treated equal but if another test module fails it wouldn't be equal anymore. Draft: https://github.com/os-autoinst/openQA/pull/3988
Updated by favogt over 3 years ago
https://progress.opensuse.org/issues/80686 might be the same as this one.
https://progress.opensuse.org/issues/70915 might be relevant as well.
Updated by mkittler over 3 years ago
- Status changed from New to In Progress
Updated by mkittler over 3 years ago
- Related to action #80686: wrong label carry-over to a job where an additional module failed before the one failing in before added
Updated by mkittler over 3 years ago
- Related to action #70915: Bugref comments carried over even if status changed failed -> incomplete added
Updated by okurz over 3 years ago
- Status changed from Feedback to Resolved
PR has been deployed meanwhile on o3 and osd. @mkittler as you created the ticket yourself I assume you are happy with the result of your changes. And as there are no further "steps to reproduce" mentioned I will set the ticket to "Resolved" and you are welcome to report back if the problem is still or again visible.