action #92665: Automatically validate code style for python code - openQA Project - openSUSE Project Management Tool

Custom queries

All 'new' issues w/o assignee, sorted by version/priority
All auto_review tickets
All auto_review+force_result tickets
openQA Infrastructure Project
openqa-review - Closed tickets last updated by openqa-review, last 30 days
QA roadmap long-term
QA SLE functional
QA SLE Functional - closed in last 14 days
QA SLE Functional - High, need to be refined
QA SLE Functional - over cycle time median
QA SLE u
QA SLE y
QA tools (tag not necessary in openQA and subprojects)
QA tools tag (tag not necessary in openQA and subprojects; excluding tickets in "Ready" version as they are already on the backlog)
QAC - Backlog
QE tools team - backlog (ready issues)
QE tools team - backlog (w/o infra)
QE tools team - backlog SLA high
QE tools team - backlog SLA immediate
QE tools team - backlog SLA no immediate/urgent in feedback/blocked
QE tools team - backlog SLA normal
QE tools team - backlog SLA urgent
QE tools team - backlog SLO high
QE tools team - backlog SLO normal
QE tools team - backlog SLO urgent
QE tools team - backlog, high-level view (epics and higher)
QE tools team - backlog, non-reactive work, needs parent
QE tools team - backlog, top-level view (all sagas)
QE tools team - closed within last 14 days
QE tools team - closed within last 60 days
QE tools team - closed yesterday
QE Tools Team - Collaborative Session
QE tools team - due date forecast
QE Tools team - due soon
QE tools team - exceeding due-date
QE tools team - infrastructure backlog
QE tools team - next - sorted by update time
QE tools team - next issues
QE tools team - non-estimated (unblocked) issues (w/o infra)
QE tools team - ready issues - Workable
QE tools team - ready, not assigned/blocked/low
QE tools team - update forecast
QE tools team - updated by priority
QE tools team - what members of the team are working on - Feedback (not-low)
QE Tools Team Backlog By Assignee
Tools Team Retrospective
Tools Team Retrospective (not estimated or assigned)

Actions

Copy link

action #92665

closed

Automatically validate code style for python code

Added by osukup almost 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Priority:

Low

Assignee:

osukup

Category:

Feature requests

Target version:

Ready

Start date:

2021-05-13

Due date:

2021-06-09

% Done:

Estimated time:

Description

Motivation¶

It would be great to have automated checks for more style aspects to python code

We use perl-Tidy and perl-Critic for perl code and strictly checks in CI, it will be nice to have same
standard also for other languages.

Acceptance criteria¶

AC1: python code style is checked automatically

Acceptance tests¶

AT1: Inconsistent codestyle prevents deployments

Suggestion¶

use black for python code style

Related issues 1 (1 open — 0 closed)

Related to openQA Project - action #93892: [beginner][easy] Automatically validate code style for python code in openQA

Workable

2021-06-11

Actions

Issue # Delay: days Cancel

History
Notes
Property changes

Actions

Copy link

Updated by okurz almost 3 years ago

Due date set to 2021-05-28
Category set to Feature requests
Status changed from New to In Progress
Assignee set to osukup
Priority changed from Normal to Low
Target version set to Ready

I agree. Let's go with https://github.com/os-autoinst/openqa_review/pull/142 in openqa-review first and then let's try to add the according checks to other projects where we use python as well.

Actions

Copy link

Updated by okurz almost 3 years ago

https://github.com/os-autoinst/openqa_review/pull/142 replaced by https://github.com/os-autoinst/openqa_review/pull/143 which got merged. https://travis-ci.org/github/os-autoinst/openqa_review/jobs/771437422#L211 shows a passed black check run within the openqa-review tests.

@osukup would you like to give it a try to bring in equivalent checks for other repos, e.g. os-autoinst and/or openQA?

Actions

Copy link

Updated by osukup almost 3 years ago

https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131
and
https://github.com/os-autoinst/os-autoinst/pull/1679

Actions

Copy link

Updated by livdywan almost 3 years ago

Due date changed from 2021-05-28 to 2021-06-02

osukup wrote:

https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131
and
https://github.com/os-autoinst/os-autoinst/pull/1679

https://github.com/os-autoinst/os-autoinst/pull/1679 is still open. @osukup please sort out remaining questions if any and ensure the PR is mergeable. I'm bumping the Due date to tomorrow in the meantime.

Actions

Copy link

Updated by osukup almost 3 years ago

cdywan wrote:

https://github.com/os-autoinst/os-autoinst/pull/1679 is still open. @osukup please sort out remaining questions if any and ensure the PR is mergeable. I'm bumping the Due date to tomorrow in the meantime.

is merged ....

new PR https://github.com/os-autoinst/openqa_bugfetcher/pull/4

Actions

Copy link

Updated by livdywan almost 3 years ago

Status changed from In Progress to Feedback

The last open PR was merged, all done?

Actions

Copy link

Updated by livdywan almost 3 years ago

Due date changed from 2021-06-02 to 2021-06-08

Actions

Copy link

Updated by livdywan almost 3 years ago

Due date changed from 2021-06-08 to 2021-06-09

So apparently a due date of "today" is pointless in terms of getting it off the list for the day.

Actions

Copy link

Updated by okurz almost 3 years ago

https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true says "No"

Actions

Copy link

#10

Updated by osukup almost 3 years ago

Status changed from Feedback to Resolved

okurz wrote:

https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true says "No"

y, code quality of bugfetcher isn't best :D and pytlint complaints a lot

but from the perspective of this ticket --> automatic check for style with black is completed in all os-autoinst project's

Actions

Copy link

#11

Updated by livdywan almost 3 years ago

Status changed from Resolved to Feedback

osukup wrote:

y, code quality of bugfetcher isn't best :D and pytlint complaints a lot

The ticket is not about black or pylint. AT1: Inconsistent codestyle prevents deployments is not fulfilled as far as I can see. So I see 3 obvious options here: