https://progress.opensuse.org/https://progress.opensuse.org/themes/openSUSE/favicon/favicon.ico?15829177842021-05-14T11:34:17ZopenSUSE Project Management ToolopenQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4072932021-05-14T11:34:17Zokurzokurz@suse.com
<ul><li><strong>Due date</strong> set to <i>2021-05-28</i></li><li><strong>Category</strong> set to <i>Feature requests</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li><li><strong>Assignee</strong> set to <i>osukup</i></li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li><li><strong>Target version</strong> set to <i>Ready</i></li></ul><p>I agree. Let's go with <a href="https://github.com/os-autoinst/openqa_review/pull/142" class="external">https://github.com/os-autoinst/openqa_review/pull/142</a> in openqa-review first and then let's try to add the according checks to other projects where we use python as well.</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4079652021-05-17T16:03:10Zokurzokurz@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/openqa_review/pull/142" class="external">https://github.com/os-autoinst/openqa_review/pull/142</a> replaced by <a href="https://github.com/os-autoinst/openqa_review/pull/143" class="external">https://github.com/os-autoinst/openqa_review/pull/143</a> which got merged. <a href="https://travis-ci.org/github/os-autoinst/openqa_review/jobs/771437422#L211" class="external">https://travis-ci.org/github/os-autoinst/openqa_review/jobs/771437422#L211</a> shows a passed black check run within the openqa-review tests.</p>
<p><a class="user active user-mention" href="https://progress.opensuse.org/users/21806">@osukup</a> would you like to give it a try to bring in equivalent checks for other repos, e.g. os-autoinst and/or openQA?</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4113812021-05-28T13:49:15Zosukup
<ul></ul><p><a href="https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131" class="external">https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131</a><br>
and<br>
<a href="https://github.com/os-autoinst/os-autoinst/pull/1679" class="external">https://github.com/os-autoinst/os-autoinst/pull/1679</a></p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4121342021-06-01T10:42:41Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> changed from <i>2021-05-28</i> to <i>2021-06-02</i></li></ul><p>osukup wrote:</p>
<blockquote>
<p><a href="https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131" class="external">https://github.com/os-autoinst/openqa-trigger-from-obs/pull/131</a><br>
and<br>
<a href="https://github.com/os-autoinst/os-autoinst/pull/1679" class="external">https://github.com/os-autoinst/os-autoinst/pull/1679</a></p>
</blockquote>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1679" class="external">https://github.com/os-autoinst/os-autoinst/pull/1679</a> is still open. <a class="user active user-mention" href="https://progress.opensuse.org/users/21806">@osukup</a> please sort out remaining questions if any and ensure the PR is mergeable. I'm bumping the <em>Due date</em> to tomorrow in the meantime.</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4122002021-06-01T14:01:08Zosukup
<ul></ul><p>cdywan wrote:</p>
<blockquote>
<p><a href="https://github.com/os-autoinst/os-autoinst/pull/1679" class="external">https://github.com/os-autoinst/os-autoinst/pull/1679</a> is still open. <a class="user active user-mention" href="https://progress.opensuse.org/users/21806">@osukup</a> please sort out remaining questions if any and ensure the PR is mergeable. I'm bumping the <em>Due date</em> to tomorrow in the meantime.</p>
</blockquote>
<p>is merged ....</p>
<p>new PR <a href="https://github.com/os-autoinst/openqa_bugfetcher/pull/4" class="external">https://github.com/os-autoinst/openqa_bugfetcher/pull/4</a></p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4138502021-06-08T06:29:23Zlivdywanliv.dywan@suse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Feedback</i></li></ul><p>The last open PR was merged, all done?</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4138532021-06-08T06:30:04Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> changed from <i>2021-06-02</i> to <i>2021-06-08</i></li></ul> openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4138562021-06-08T06:31:58Zlivdywanliv.dywan@suse.com
<ul><li><strong>Due date</strong> changed from <i>2021-06-08</i> to <i>2021-06-09</i></li></ul><p>So apparently a <em>due date</em> of "today" is pointless in terms of getting it off the list for the day.</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4140952021-06-08T13:09:55Zokurzokurz@suse.com
<ul></ul><p><a href="https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true" class="external">https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true</a> says "No"</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4142542021-06-08T14:40:15Zosukup
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul><p>okurz wrote:</p>
<blockquote>
<p><a href="https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true" class="external">https://github.com/os-autoinst/openqa_bugfetcher/runs/2763136167?check_suite_focus=true</a> says "No"</p>
</blockquote>
<p>y, code quality of bugfetcher isn't best :D and pytlint complaints a lot</p>
<p>but from the perspective of this ticket --> automatic check for style with black is completed in all os-autoinst project's</p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4142722021-06-08T15:24:37Zlivdywanliv.dywan@suse.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul><p>osukup wrote:</p>
<blockquote>
<p>y, code quality of bugfetcher isn't best :D and pytlint complaints a lot</p>
</blockquote>
<p>The ticket is not about black or pylint. <code>AT1: Inconsistent codestyle prevents deployments</code> is not fulfilled as far as I can see. So I see 3 obvious options here:</p>
<ul>
<li>Drop <em>pylint</em></li>
<li>Fix <em>pylint</em></li>
<li>File a ticket about why fixing <em>pylint</em> is non-trivial</li>
</ul>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4143292021-06-08T19:25:23Zosukup
<ul></ul><p><a href="https://github.com/os-autoinst/openqa_bugfetcher/pull/5" class="external">https://github.com/os-autoinst/openqa_bugfetcher/pull/5</a></p>
openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4146022021-06-09T09:58:32Zosukup
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li></ul> openQA Project - action #92665: Automatically validate code style for python codehttps://progress.opensuse.org/issues/92665?journal_id=4156332021-06-11T10:38:26Ztinitatina.mueller+trick-redmine@suse.com
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-12 priority-3 priority-lowest" href="/issues/93892">action #93892</a>: [beginner][easy] Automatically validate code style for python code in openQA</i> added</li></ul>