action #91878
closedcoordination #39719: [saga][epic] Detection of "known failures" for stable tests, easy test results review and easy tracking of known issues
coordination #19720: [epic] Simplify investigation of job failures
Improve git log entries in failed test investigation
Added by ybonatakis over 3 years ago. Updated about 3 years ago.
0%
Description
As for now the investigation shows commits and the files that changed separately.
I believe this would be more useful if files' changes were represented below each commit such us know what changed what.
So for instance test_diff_stat and test_log could be one entity.
Proposed represantation...Proposed represantation...
❯ git log --stat --oneline HEAD~3..HEAD
7d0a7d2d5 (HEAD -> 91821_rootless_podman, upstream/master, master) Merge pull request #12401 from rwx788/pvm
1cd0b8439 Merge pull request #12420 from rfan1/mok_util
16d2d6653 Add extend key usage CodeSigning for mok
data/openssl/gencert_conf/mok_cert.conf | 1 +
1 file changed, 1 insertion(+)
bab858b35 Merge pull request #12395 from tinawang123/zypperlr
5f3aaf134 Use get_required_var when connecting to the libyui REST API
lib/YuiRestClient.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
6cb028ee8 Remove unused code in the setup_libyui test module
tests/installation/setup_libyui.pm | 1 -
1 file changed, 1 deletion(-)
93107e863 Introduce is_ssh_installation method
lib/Utils/Backends.pm | 20 ++++++++++++++++++--
tests/installation/setup_libyui.pm | 4 ++--
2 files changed, 20 insertions(+), 4 deletions(-)
876c02b53 Set YUI REST API parameters for ssh installations
lib/YuiRestClient.pm | 9 +++++++--
lib/bootloader_pvm.pm | 8 +++++++-
tests/installation/bootloader_zkvm.pm | 6 +++++-
tests/installation/setup_libyui.pm | 8 +++++++-
4 files changed, 26 insertions(+), 5 deletions(-)
3d27891b2 Check the product and modules repos after migration via zypper lr output information
products/sle/main.pm | 4 ++--
schedule/migration/aarch64_regression_test_offline.yaml | 1 +
schedule/migration/aarch64_regression_test_online.yaml | 1 +
schedule/migration/offline_spvm_Upgrade.yaml | 1 +
schedule/migration/ppc64le_regression_test_offline.yaml | 1 +
schedule/migration/ppc64le_regression_test_online.yaml | 1 +
schedule/migration/s390x-zVM-Upgrade.yaml | 1 +
schedule/migration/s390x_regression_test_offline.yaml | 1 +
schedule/migration/s390x_regression_test_online.yaml | 1 +
schedule/migration/x86_regression_test_offline.yaml | 1 +
schedule/migration/x86_regression_test_online.yaml | 1 +
tests/console/check_system_info.pm | 23 +++++++++++++++++++++++
12 files changed, 35 insertions(+), 2 deletions(-)
Updated by okurz over 3 years ago
- Subject changed from [OpenQA] Improve failed test investigation to Improve failed test investigation
- Due date set to 2021-05-27
- Status changed from New to Feedback
- Assignee set to okurz
- Priority changed from Normal to Low
- Target version set to future
Hi, thanks for the ticket. So, instead of separate log+diff you would prefer a mixed git log with details. I guess personal preferences differ here. Do you know that others would prefer the same? I doubt that the mixed log is easier to read by users.
Updated by ybonatakis over 3 years ago
okurz wrote:
Hi, thanks for the ticket. So, instead of separate log+diff you would prefer a mixed git log with details. I guess personal preferences differ here. Do you know that others would prefer the same? I doubt that the mixed log is easier to read by users.
i do not know about others. I dont even know how many they use them or how.
IMO it is a clearer investigation approach because you can see which commit changes what files that it might cause the problem. Also with good comments is easier to walk through the commits and see what was merged with all the context in one look. Otherwise you have to go first in one panel see what files are changed and then go find the corresponding commit. Until this time you miss the description of the commit to see if it is relavant. And the other way around.
Updated by okurz over 3 years ago
We discussed this in the SUSE QE Tools Workshop 2021-05-14 as well. We see it as a viable alternative to make the git hash clickable, e.g. pointing to the corresponding github view for the git hash.
Updated by ybonatakis over 3 years ago
okurz wrote:
We discussed this in the SUSE QE Tools Workshop 2021-05-14 as well. We see it as a viable alternative to make the git hash clickable, e.g. pointing to the corresponding github view for the git hash.
or both? i see this as a interchangeable and interdependent enhancement
Updated by okurz over 3 years ago
sure, we can try both. So far I have not heard or read from anyone else that they would think the approach of combined log+stat as necessary but maybe you want to give it a try yourself in openQA code around the code in https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Schema/Result/Jobs.pm#L1987 ? I can't make promises if we want to accept such PR but we can try to discuss over code rather just english text :)
Updated by okurz over 3 years ago
- Subject changed from Improve failed test investigation to Improve git log entries in failed test investigation
- Due date deleted (
2021-05-27) - Status changed from Feedback to Workable
- Assignee deleted (
okurz)
I split out the "clickable git log entries" into #92731 . @ybonatakis as stated, you are welcome to give it a try. Within SUSE QE Tools we need to postpone the feature a bit.
Updated by ybonatakis over 3 years ago
okurz wrote:
sure, we can try both. So far I have not heard or read from anyone else that they would think the approach of combined log+stat as necessary but maybe you want to give it a try yourself in openQA code around the code in https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/Schema/Result/Jobs.pm#L1987 ? I can't make promises if we want to accept such PR but we can try to discuss over code rather just english text :)
https://github.com/os-autoinst/openQA/pull/3993 talk time :)
Updated by ybonatakis over 3 years ago
- Status changed from Workable to Feedback
Updated by livdywan over 3 years ago
- Status changed from Feedback to In Progress
I suspect this should be in progress as there's a very nice looking PR under review
Updated by livdywan over 3 years ago
- Related to action #92731: clickable git log entries in investigation tab added
Updated by ybonatakis about 3 years ago
i checked o3 and the links are not getting the correct url. the url looks like https://github.com/os-autoinst/os-autoinst-distri-opensuse.gitc3e0fc6e8 when it is supposed to be https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/c3e0fc6e8.
Somehow this appears only on test_log. needles_log works fine
Updated by ybonatakis about 3 years ago
the problem with the dropdown link was fixed but the test_log link is still rendered wrongly
Updated by ybonatakis about 3 years ago
https://github.com/os-autoinst/openQA/pull/4366 submitted for url correction
Updated by ybonatakis about 3 years ago
- Status changed from In Progress to Resolved
The feature look in place now and works as expected. I still see things that need some improvement and i will try to take a look when i will have time. So instance i show some old jobs which complain that they cannot get the git stat(Invalid revision range[0]) but i assume that this was already an defect or it is a different problem from this task.
i am going to resolve this