QA (public) » openQA Project (public)

In the meeting we said a client-side solution would be difficult because we needed to replace the URLs after the overall page has loaded and doing so would be disturbing as it affects the layout. However, it could be implemented in a way that before the job status is known a loading circle is rendered which is replaced by a status circle of the same size when the status is known and the job's name would only be added as tooltip. The link text could be folded to "job#1234" from the beginning. This way the layout would not change suddenly.

mkittler wrote:

In the meeting we said a client-side solution would be difficult because we needed to replace the URLs after the overall page has loaded and doing so would be disturbing as it affects the layout. However, it could be implemented in a way that before the job status is known a loading circle is rendered which is replaced by a status circle of the same size when the status is known and the job's name would only be added as tooltip. The link text could be folded to "job#1234" from the beginning. This way the layout would not change suddenly.

So rather than 🔴kde-wayland@aarch64 it would be 🔴job#1868683?

If we decide we can't render the name I would rather stick to the URL since job# is not a common way to refer to jobs. So it would be 🔴https://openqa.opensuse.org/tests/1868683.

That said I'd strongly prefer rendering the name somehow. We could show empty comments until we have the job names (or time out and show it verbatim).

cdywan wrote:

[…]
If we decide we can't render the name I would rather stick to the URL since job# is not a common way to refer to jobs. So it would be 🔴https://openqa.opensuse.org/tests/1868683.

That said I'd strongly prefer rendering the name somehow.

Why care about the name? I think only the job result is important for now. That should make implementation easier.

We could show empty comments until we have the job names (or time out and show it verbatim).

Why not just add the job status icon after the URL whenever we managed to receive that data?

While rendering the job states/results in javascript and trying to reuse existing code, I stumbled upon a little bug in the activity view:
https://github.com/os-autoinst/openQA/commit/203d1d7d3289c2007b724c8e468dd42299772f12#diff-fae8284b51d426d67a2d9bb8590c1f8e06151d909a34a7e67f36bdc2038907e9R335

Running and Scheduled won't be rendered as they are inside a if (job.state === 'done')

I think I found another bug.
The activity view is supposed to poll jobs which are not yet finished and display the updated status.
However, the code

https://github.com/os-autoinst/openQA/blob/master/assets/javascripts/openqa.js#L377

  // continue polling for job state updates until the job state is done
  if (job.state !== 'done') {
    setTimeout(updateTestState, 5000);
  }

Does not pass any arguments to updateTestState.
If I change it to

  // continue polling for job state updates until the job state is done
  if (job.state !== 'done') {
    setTimeout(function() { updateTestState(job, name, timeago, reason) }, 5000);
  }

Then it calls the function repeatly, but that doesn't do the http request.

PR for fixing the status icons in activity view: https://github.com/os-autoinst/openQA/pull/4175

PR merged